tendermint

Commit Graph

Author	SHA1	Message	Date
Marko	513a32a6e3	gocritic (1/2) (#3836 ) Add gocritic as a linter The linting is not complete, but should i complete in this PR or in a following. 23 files have been touched so it may be better to do in a following PR Commits: * Add gocritic to linting - Added gocritic to linting Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * gocritic * pr comments * remove switch in cmdBatch	5 years ago
Thane Thomson	62f97a69e9	abci: Refactor CheckTx to notify of recheck (#3744 ) As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states). In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client. And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure: enum CheckTxType { New = 0; Recheck = 1; } message RequestCheckTx { bytes tx = 1; CheckTxType type = 2; } * Refactor ABCI CheckTx to notify of recheck As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for: 1. a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states) 2. an `additional_data` bytes array to provide information for those more nuanced states. In order to pass this extended information through to the ABCI app, the `proxy.AppConnMempool` (and, for consistency, the `proxy.AppConnConsensus`) interface seems to need to be refactored. Commits: * Fix linting issue * Add CHANGELOG_PENDING entry * Remove extraneous explicit initialization * Update ABCI spec doc to include new CheckTx params * Rename method param for consistency * Rename CheckTxType enum values and remove additional_data param	6 years ago
Anton Kaliaev	cdf3a74f48	Unclean shutdown on SIGINT / SIGTERM (#3308 ) * libs/common: TrapSignal accepts logger as a first parameter and does not block anymore * previously it was dumping "captured ..." msg to os.Stdout * TrapSignal should not be responsible for blocking thread of execution Refs #3238 * exit with zero (0) code upon receiving SIGTERM/SIGINT Refs #3238 * fix formatting in docs/app-dev/abci-cli.md Co-Authored-By: melekes <anton.kalyaev@gmail.com> * fix formatting in docs/app-dev/abci-cli.md Co-Authored-By: melekes <anton.kalyaev@gmail.com>	6 years ago
Anton Kaliaev	7fd51e6ade	make govet linter pass (#3292 ) * make govet linter pass Refs #3262 * close PipeReader and check for err	6 years ago
Zach	0ff715125b	fix docs / proxy app (#2988 ) * fix docs / proxy app, closes #2986 * counter_serial * review comments * list all possible options * add changelog entries	6 years ago
Joon	71a34adfe5	General Merkle Proof (#2298 ) * first commit finalize rebase add protoc_merkle to Makefile * in progress * fix kvstore * fix tests * remove iavl dependency * fix tx_test * fix test_abci_cli fix test_apps * fix test_apps * fix test_cover * rm rebase residue * address comment in progress * finalize rebase	6 years ago
bradyjoestar	ad24d66750	[abci-cli] print out all the sub-commands available (#2219 )	6 years ago
Anton Kaliaev	96ae535fb8	proto3 timestamp (#2064 ) This PR changes ABCI time format from int64 (Unix seconds) to WKT (WellKnownType) google.protobuf.Timestamp. Refs #1857 Reasons: better precision standard DT for proto * update Gopkg.lock * [makefile] remove extra grep - go list excludes vendor by default now * proto3 timestamp * [docs/abci-spec] note about serialisation format * make time non-nullable	7 years ago
Zach Ramsay	44dad6d70b	Revert "detele everything" This reverts commit `d02c5d1e30`.	7 years ago
Zach Ramsay	d02c5d1e30	detele everything	7 years ago
Ethan Buchman	d55243f0e6	fix import paths	7 years ago
Alexander Simmerl	a605b66c5a	Move abci imports	7 years ago

11 Commits (76f3db06b8dbbfe5d6c4d0f4a6131b58ed36869d)