Anton Kaliaev
|
709cf18aef
|
add gofuzz test for consensus wal
|
7 years ago |
Anton Kaliaev
|
e57cad6c3f
|
correct maxMsgSizeBytes
|
7 years ago |
Anton Kaliaev
|
06aece31cf
|
lower the max message size
|
7 years ago |
Anton Kaliaev
|
af79a2a59e
|
fix error msg
|
7 years ago |
Anton Kaliaev
|
ee66476d62
|
set max msg size
otherwise, it is easy to get OutOfMemory panic (somebody can even expoit
this)
|
7 years ago |
Anton Kaliaev
|
40f9261d48
|
handle data corruption errors
Refs #573
|
7 years ago |
Ricardo Domingos
|
59e89e7664
|
consensus: Fix typo on ticker.go documentation
|
7 years ago |
Anton Kaliaev
|
90944bb1a2
|
be specific about what type we're encoding
to be consistent with Decode, which returns TimedWALMessage
|
7 years ago |
Anton Kaliaev
|
07571741c5
|
[consensus] remove WAL separator (Refs #785)
We don't really need a separator unless we have complex structures
(rows, cells like RDBMS have https://www.sqlite.org/fileformat.html).
|
7 years ago |
Anton Kaliaev
|
5cb936fa00
|
fixes after my own review
|
7 years ago |
Anton Kaliaev
|
c6f025f40e
|
generate WAL on the fly (Refs #468)
|
7 years ago |
Ethan Buchman
|
9af8da7aad
|
update for new abci int types
|
7 years ago |
Anton Kaliaev
|
cd5a5d332f
|
remove comments for uint64 related to possible underflow [ci skip]
|
7 years ago |
Anton Kaliaev
|
89cbcceac4
|
error if app returned negative last block height (Fixes #911)
|
7 years ago |
Anton Kaliaev
|
922af7c405
|
int64 height
uint64 is considered dangerous. the details will follow in a blog post.
|
7 years ago |
Anton Kaliaev
|
f1fbf995f7
|
protect ourselves again underflow (Refs #911)
|
7 years ago |
Anton Kaliaev
|
86af889dfb
|
remove unnecessary casts (Refs #911)
|
7 years ago |
Anton Kaliaev
|
b3492356e6
|
uint64 height (Refs #911)
|
7 years ago |
Anton Kaliaev
|
1e19860585
|
fixes from my own review
|
7 years ago |
Anton Kaliaev
|
f65e357d2b
|
adapt Tendermint to new abci.Client interface
which was introduced in https://github.com/tendermint/abci/pull/130
|
7 years ago |
Anton Kaliaev
|
a52cdbfe43
|
extract tags from DeliverTx/Result
and send them along with predefined
|
7 years ago |
Anton Kaliaev
|
69b5da766c
|
service#Start, service#Stop signatures were changed
See https://github.com/tendermint/tmlibs/issues/45
|
7 years ago |
Ethan Buchman
|
9529f12c28
|
more linting
|
7 years ago |
Ethan Buchman
|
55b81cc1a1
|
address linting FIXMEs
|
7 years ago |
Zach Ramsay
|
c4caad7720
|
lint madness
|
7 years ago |
Zach Ramsay
|
2563b4fc92
|
lint fixes
|
7 years ago |
Zach Ramsay
|
6f3c05545d
|
fix new linting errors
|
7 years ago |
Zach Ramsay
|
7ad8a8ab55
|
Tests almost passing
|
7 years ago |
Zach Ramsay
|
a15c7f221d
|
linting: moar fixes
|
7 years ago |
Zach Ramsay
|
d7cb291fb2
|
errcheck; sort some stuff out
|
7 years ago |
Zach Ramsay
|
563faa98de
|
address comments, pr #643
|
7 years ago |
Zach Ramsay
|
bc2aa79f9a
|
linter: sort through each kind and address small fixes
|
7 years ago |
Zach Ramsay
|
48aca642e3
|
linter: address deadcode, implement incremental lint testing
|
7 years ago |
Zach Ramsay
|
68e7983c70
|
linting errors: afew more
|
7 years ago |
Zach Ramsay
|
8f0237610e
|
linting errors: clean it all up
|
7 years ago |
Zach Ramsay
|
b75d4f73e7
|
errcheck: PR comment fixes
|
7 years ago |
Zach Ramsay
|
331857c9e6
|
linting: apply errcheck part2
|
7 years ago |
Zach Ramsay
|
57ea4987f7
|
linting: apply errcheck part1
|
7 years ago |
Zach Ramsay
|
46ccbcbff6
|
linting: apply 'gofmt -s -w' throughout
|
7 years ago |
Emmanuel Odeke
|
42da8cd297
|
consensus/WAL: benchmark WALDecode across data sizes
|
7 years ago |
Anton Kaliaev
|
fa60d8120e
|
fix TestFullRound1 race (Refs #846)
```
==================
WARNING: DATA RACE
Write at 0x00c42d7605f0 by goroutine 844:
github.com/tendermint/tendermint/consensus.(*ConsensusState).updateToState()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:465 +0x59e
I[11-14|22:37:28.781] Added to prevote vote="Vote{0:646753DCE124 1/02/1(Prevote) E9B19636DCDB {/CAD5FA805E8C.../}}" prevotes="VoteSet{H:1 R:2 T:1 +2/3:<nil> BA{2:X_} map[]}"
github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1229 +0x16a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1135 +0x721
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1087 +0x153
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1114 +0xa34
github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1423 +0xdd6
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1317 +0x77
github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:565 +0x7a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:523 +0x6d2
Previous read at 0x00c42d7605f0 by goroutine 654:
github.com/tendermint/tendermint/consensus.validatePrevote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:149 +0x57
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:256 +0x3c5
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 844 (running) created at:
github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:258 +0x8c
github.com/tendermint/tendermint/consensus.startTestRound()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:118 +0x63
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:247 +0x1fb
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 654 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:789 +0x568
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1004 +0xa7
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
testing.runTests()
/usr/local/go/src/testing/testing.go:1002 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:921 +0x206
main.main()
github.com/tendermint/tendermint/consensus/_test/_testmain.go:106 +0x1d3
==================
```
|
7 years ago |
Ethan Buchman
|
aba8a8f4fc
|
consensus: crank timeout in timeoutWaitGroup
|
7 years ago |
Ethan Buchman
|
0448c2b437
|
consensus: fix LastCommit log
|
7 years ago |
Anton Kaliaev
|
7fa12662c4
|
check whatever we can read from the channel
```
panic: interface conversion: interface {} is nil, not types.TMEventData
goroutine 7690 [running]:
github.com/tendermint/tendermint/consensus.waitForAndValidateBlock.func1(0xc427727620, 0x3)
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:292 +0x62b
created by github.com/tendermint/tendermint/consensus.timeoutWaitGroup
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:349 +0xa4
exit status 2
FAIL github.com/tendermint/tendermint/consensus 38.614s
```
|
7 years ago |
Ethan Buchman
|
2cda777900
|
consensus: make mempool_test deterministic
|
7 years ago |
Anton Kaliaev
|
a1cdc2b68a
|
set logger for peer's MConnection
|
7 years ago |
Anton Kaliaev
|
ad03491ee6
|
remove duplicated key
|
7 years ago |
Ethan Buchman
|
4b9dfc8990
|
consensus: fix for initializing block parts during catchup
|
7 years ago |
Ethan Buchman
|
47f5e37205
|
copy RoundState for event
|
7 years ago |
Anton Kaliaev
|
e0daca5693
|
fixes from Bucky's review
|
7 years ago |