Author | SHA1 | Message | Date |
---|---|---|---|
Sam Kleinman |
2ff962a63a
|
log: dissallow nil loggers (#7445) | 3 years ago |
Sam Kleinman |
d0e03f01fc
|
sync: remove special mutexes (#7438) | 3 years ago |
Sam Kleinman |
d7606777cf
|
libs/service: pass logger explicitly (#7288)
This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome. |
3 years ago |
Sam Kleinman |
34a3fcd8fc
|
Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106)
This reverts commit
|
3 years ago |
Sam Kleinman |
9dfdc62eb7
|
proxy: move proxy package to internal (#6953) | 3 years ago |