tendermint

354 Commits

183 Branches

291 MiB

Tree: 6ec8c1602f

Commit Graph

Author	SHA1	Message	Date
Anton Kaliaev	65a07b80a3	change logger interface to not return errors (Refs #50 ) See https://github.com/go-kit/kit/issues/164 for discussion of why kitlog returns an error. ``` Package log is designed to be used for more than simple application info/warning/error logging; it's suitable for log-structured data in an e.g. Lambda architecture, where each invocation is important. I agree with you that if we were doing only application logging the error would be more noise than signal. But the scope of the package is larger than that. ``` Since we are doing only application logging and we're not checking errors, it is safe to get rid them.	7 years ago
Anton Kaliaev	ddaa4d9b4c	[log] tracing logger	8 years ago

Author

SHA1

Message

Date

Anton Kaliaev

65a07b80a3

change logger interface to not return errors (Refs #50 )

See https://github.com/go-kit/kit/issues/164 for discussion of why
kitlog returns an error.

```
Package log is designed to be used for more than simple application info/warning/error logging; it's suitable for log-structured data in an e.g. Lambda architecture, where each invocation is important. I agree with you that if we were doing only application logging the error would be more noise than signal. But the scope of the package is larger than that.
```

Since we are doing only application logging and we're not checking
errors, it is safe to get rid them.

7 years ago

Anton Kaliaev

ddaa4d9b4c

[log] tracing logger

8 years ago

2 Commits (6ec8c1602f22f41fc320da05c3a80acebf2c23bd)