Anton Kaliaev
aae4e94998
make RPCRequest params not a pointer
https://github.com/tendermint/tendermint/pull/724#issuecomment-335362927
7 years ago
Anton Kaliaev
d935a4f0a8
recover from panic in WS JSON RPC readRoutine
https://github.com/tendermint/tendermint/pull/724#issuecomment-335316484
7 years ago
Anton Kaliaev
5c331d8276
log a notification to help debug user issues
7 years ago
Anton Kaliaev
a3adac3787
[rpc] do not try to parse params if they were not provided (Refs #708 )
7 years ago
Alexandre Thibault
382bead548
rpc: fix client websocket timeout ( #687 )
7 years ago
Anton Kaliaev
f8b152972f
return method not found error
if somebody tries to access WS method in non-ws context
7 years ago
Anton Kaliaev
7fadde0b37
check for request ID after receiving it
7 years ago
Anton Kaliaev
f74de4cb86
include optional data field in error object
```
data
A Primitive or Structured value that contains additional information about the error.
This may be omitted.
The value of this member is defined by the Server (e.g. detailed error information, nested errors etc.).
```
8 years ago
Dave Bryson
60a1f49a5c
updated json response to match spec by @davebryson
8 years ago
Ethan Buchman
9dde1a0bd4
rpc: comments
7 years ago
Anton Kaliaev
2fd8496bc1
correct handling of pings and pongs
server:
- always has read & write timeouts
- ping handler never blocks the reader (see A)
- sends regular pings to check up on a client
A:
at some point server write buffer can become full, so in order not to
block reads from a client (see
https://github.com/gorilla/websocket/issues/97 ), server may skip some
pongs. As a result, client may disconnect. But you either have to do
that or block the reader. There is no third way.
client:
- optional read & write timeouts
- optional ping/pong to measure latency
7 years ago
Anton Kaliaev
9b5f21a650
[ws-server] reset readTimeout when we receive something
8 years ago
Anton Kaliaev
6c85e4be4f
change server ping period to be less frequent
no need to ping ws every 10 sec
8 years ago
Anton Kaliaev
c14b39da5f
make RPC server's ping period and pong wait configurable via options
8 years ago
Ethan Buchman
0d1fa8e884
fixes from review
8 years ago
Ethan Buchman
e2ed15fa02
rpc: SetWriteDeadline for ws ping. fixes #553
8 years ago
Ethan Buchman
b6031d5f4b
rpc/lib: set logger on ws conn
8 years ago
Anton Kaliaev
b4ece65726
standardize key for errors (should be "err")
8 years ago
Ethan Frey
2b324b7eb9
RPC returns pretty formated json
8 years ago
Anton Kaliaev
f803544195
new logging
8 years ago
Ethan Buchman
75989342b0
fixes from rebase
8 years ago
Ethan Buchman
9860c8fee1
rpc: cleanup some comments [ci skip]
8 years ago
Ethan Frey
4a1b714ca4
All tests pass without go-wire json ptr madness
8 years ago
Ethan Frey
4c1d41c12e
Test json rpc parsing
8 years ago
Ethan Frey
6ba799132c
json.RawMessage in RPCRequest to defer parsing
8 years ago
Ethan Buchman
6dbcfb32d2
comment on copied wire file
8 years ago
Ethan Buchman
efeadcc0f4
some cleanup from review
8 years ago
Ethan Buchman
ac28b12fa8
add readReflectJSON from wire
8 years ago
Ethan Frey
257f45b768
ebuchman: added some demos on how to parse unknown types
8 years ago
Ethan Buchman
acfbea6d49
rpc: decode args without wire
8 years ago
Ethan Frey
6c60c07f16
BROKEN: attempt to replace go-wire.JSON with json.Unmarshall in rpc
8 years ago
Ethan Buchman
cc6dde96c1
rpc -> rpc/lib and rpc/tendermint -> rpc
8 years ago