Alexandre Thibault
ce36a0111a
rpc: subscribe on reconnection ( #689 )
* rpc: subscribe on reconnection
* rpc: fix unit tests
7 years ago
Alexandre Thibault
382bead548
rpc: fix client websocket timeout ( #687 )
7 years ago
Anton Kaliaev
f9479b34cb
sleep time should be greater than readTimeout (5 sec)
otherwise, we're not testing ping/pongs.
see https://github.com/tendermint/tendermint/pull/687#issuecomment-332494735
7 years ago
Ethan Buchman
ddb3d8945d
p2p: allow listener with no external connection
7 years ago
Anton Kaliaev
f8b152972f
return method not found error
if somebody tries to access WS method in non-ws context
7 years ago
Anton Kaliaev
95875c55fc
ID must be present in both request and response
from the spec:
This member is REQUIRED.
It MUST be the same as the value of the id member in the Request Object.
If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null.
7 years ago
Anton Kaliaev
7fadde0b37
check for request ID after receiving it
7 years ago
Anton Kaliaev
e36c79f713
capitalize RpcError
7 years ago
Anton Kaliaev
b700ed8e31
remove check for non-empty message as it should always be present
7 years ago
Anton Kaliaev
f74de4cb86
include optional data field in error object
```
data
A Primitive or Structured value that contains additional information about the error.
This may be omitted.
The value of this member is defined by the Server (e.g. detailed error information, nested errors etc.).
```
7 years ago
Anton Kaliaev
6c1572c9b8
fix invalid memory address or nil pointer dereference
7 years ago
Dave Bryson
60a1f49a5c
updated json response to match spec by @davebryson
7 years ago
Ethan Buchman
9dde1a0bd4
rpc: comments
7 years ago
Anton Kaliaev
2fd8496bc1
correct handling of pings and pongs
server:
- always has read & write timeouts
- ping handler never blocks the reader (see A)
- sends regular pings to check up on a client
A:
at some point server write buffer can become full, so in order not to
block reads from a client (see
https://github.com/gorilla/websocket/issues/97 ), server may skip some
pongs. As a result, client may disconnect. But you either have to do
that or block the reader. There is no third way.
client:
- optional read & write timeouts
- optional ping/pong to measure latency
7 years ago
Anton Kaliaev
236489aecf
backlog must always have higher priority
7 years ago
Ethan Buchman
797acbe911
ws: small comment
7 years ago
Anton Kaliaev
9b5f21a650
[ws-server] reset readTimeout when we receive something
7 years ago
Anton Kaliaev
8267920749
[ws-client] write normal close message
7 years ago
Anton Kaliaev
6c85e4be4f
change server ping period to be less frequent
no need to ping ws every 10 sec
7 years ago
Anton Kaliaev
23a87304cc
add a comment for PingPongLatencyTimer [ci skip]
7 years ago
Anton Kaliaev
c14b39da5f
make RPC server's ping period and pong wait configurable via options
7 years ago
Anton Kaliaev
57eee2466b
make WSClient thread-safe
7 years ago
Anton Kaliaev
5d66d1c28c
fixes from review
7 years ago
Anton Kaliaev
0013053fae
allow to change pong wait and ping period
7 years ago
Anton Kaliaev
1abbb11b44
do not exit from reconnectRoutine!
7 years ago
Anton Kaliaev
54903adeff
add IsReconnecting and IsActive methods
7 years ago
Anton Kaliaev
c08618f7e9
expose latency timer on WSClient
7 years ago
Anton Kaliaev
d578f7f81e
biff up WS client
What's new:
- auto reconnect
- ping/pong
- colored tests
7 years ago
Ethan Buchman
0d1fa8e884
fixes from review
7 years ago
Ethan Buchman
e2ed15fa02
rpc: SetWriteDeadline for ws ping. fixes #553
7 years ago
Ethan Buchman
b6031d5f4b
rpc/lib: set logger on ws conn
7 years ago
Ethan Buchman
5c29d7aba9
rpc/lib: test tcp and unix
7 years ago
Ethan Frey
aac85a14f0
httpDialer accepts no prefix or http:// as tcp://
7 years ago
Anton Kaliaev
b4ece65726
standardize key for errors (should be "err")
7 years ago
Ethan Frey
2b324b7eb9
RPC returns pretty formated json
7 years ago
Anton Kaliaev
f8fdbe3dbc
changes as per Bucky's review
7 years ago
Anton Kaliaev
f803544195
new logging
7 years ago
Ethan Buchman
75989342b0
fixes from rebase
7 years ago
Ethan Buchman
9860c8fee1
rpc: cleanup some comments [ci skip]
7 years ago
Ethan Frey
4a1b714ca4
All tests pass without go-wire json ptr madness
7 years ago
Ethan Frey
4c1d41c12e
Test json rpc parsing
7 years ago
Ethan Frey
6ba799132c
json.RawMessage in RPCRequest to defer parsing
7 years ago
Ethan Buchman
6dbcfb32d2
comment on copied wire file
7 years ago
Ethan Buchman
efeadcc0f4
some cleanup from review
7 years ago
Ethan Buchman
884060eb9b
rpc/lib: no Result wrapper
7 years ago
Ethan Buchman
07e59e63f9
TMEventDataInner
7 years ago
Ethan Buchman
ac28b12fa8
add readReflectJSON from wire
7 years ago
Ethan Frey
257f45b768
ebuchman: added some demos on how to parse unknown types
7 years ago
Ethan Buchman
acfbea6d49
rpc: decode args without wire
7 years ago
Ethan Frey
6c60c07f16
BROKEN: attempt to replace go-wire.JSON with json.Unmarshall in rpc
7 years ago