tendermint

9304 Commits

183 Branches

291 MiB

Tree: 44b5d330b0

Commit Graph

Author	SHA1	Message	Date
Sam Kleinman	d7606777cf	libs/service: pass logger explicitly (#7288 ) This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	3 years ago
Sam Kleinman	1b5bb5348f	p2p: cleanup unused arguments (#7079 ) This is mostly just reading through the output of uparam, after noticing that there were a few places where we were ignoring some arguments.	3 years ago
Callum Waters	60a6c6fb1a	e2e: allow running of single node using the e2e app (#6982 )	3 years ago

Author

SHA1

Message

Date

Sam Kleinman

d7606777cf

libs/service: pass logger explicitly (#7288 )

This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.

The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.

3 years ago

Sam Kleinman

1b5bb5348f

p2p: cleanup unused arguments (#7079 )

This is mostly just reading through the output of uparam, after
noticing that there were a few places where we were ignoring some arguments.

3 years ago

Callum Waters

60a6c6fb1a

e2e: allow running of single node using the e2e app (#6982 )

3 years ago

3 Commits (44b5d330b07103d079dfbbe610f4cdba914fdbc6)