tendermint

291 MiB

Tree: 3d98504c4c

Author	SHA1	Message	Date
Anton Kaliaev	d71d1394ec	call fsync after flush (Refs #573 ) short: flushing the bufio buffer is not enough to ensure data consistency. long: Saving an entry to the WAL calls writeLine to append data to the autofile group backing the WAL, then calls group.Flush() to flush that data to persistent storage. group.Flush() in turn proxies to headBuf.flush(), flushing the active bufio.BufferedWriter. However, BufferedWriter wraps a Writer, not another BufferedWriter, and the way it flushes is by calling io.Writer.Write() to clear the BufferedWriter's buffer. The io.Writer we're wrapping here is AutoFile, whose Write method calls os.File.Write(), performing an unbuffered write to the operating system, where, I assume, it sits in the OS buffers awaiting sync. This means that Wal.Save does not, in fact, ensure the saved operation is synced to disk before returning.	7 years ago
Anton Kaliaev	74a7f8c92b	[autofile] close file before renaming it this might fix our windows bug https://github.com/tendermint/tendermint/issues/444 `0980f8e197`	8 years ago
Ethan Buchman	2f8551d3b6	go-common -> tmlibs	8 years ago
Ethan Buchman	900be74e8f	update import paths	8 years ago
Ethan Buchman	a893bb119b	merge go-autofile	8 years ago