## Description

In protobuf `[]byte` is varint encoded. When adding txs to the block we were not taking this into account. 


Closes: #XXX

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>

Remove Response/Request SetOption from ABCI.

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

## Description

Closes: #5432

Closes #2589

also, document consensus parameters.
https://forum.cosmos.network/t/consensus-timeouts-explained/1421

Closes #4489

Fixes #5377 and comments in #4588 (review).

evidence: modify evidence types (#5342)

light: detect light client attacks (#5344)

evidence: refactor evidence pool (#5345)

abci: application evidence prepared by evidence pool (#5354)

## Description

Make an interface for the state store. 

Closes: #5213

## Description

Enable errcheck linter throughout the codebase

Closes: #5059

## Description

Work towards enabling errcheck

ref #5059

## Description

When downloading mockery I ran into an issue where we were using the old version. This PR updates to a more recent version.

changelog?

Closes: #XXX

Fixes #5138. I don't have a strong opinion on this, but find it sort of odd that `Load` functions actually save as well.

Adds a genesis parameter `initial_height` which specifies the initial block height, as well as ABCI `RequestInitChain.InitialHeight` to pass it to the ABCI application, and `State.InitialHeight` to keep track of the initial height throughout the code. Fixes #2543, based on [RFC-002](https://github.com/tendermint/spec/pull/119). Spec changes in https://github.com/tendermint/spec/pull/135.

adds blockstore interface to evidence and adds fix to byzantine test

* fix usage of time in abci evidence

* update changelong and upgrading

* add test cases

See ADR 058

Closes #5113

Spec PR: https://github.com/tendermint/spec/pull/122

Solves #5138 in the way that if a validatorSet is nil or empty it will not try to transform it to protobug

Co-authored-by: Callum Michael Waters <cmwaters19@gmail.com>

ValidateBasic() for PotentialAmnesiaEvidence checks that the rounds of the two votes are different and does not check Vote Type

ValidateBasic() now also ensures that the first block is not a nil block (else the validator hasn't actually locked onto a block)

## Description
linter version fix and run make format to have all ci run

Closes: #XXX

## Description

add more error checks to tests


gonna do a third PR that tackles the non test cases

## Description

partially cleanup in preparation for errcheck

i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck.

ref #5059

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

fix bug so that PotentialAmnesiaEvidence is being gossiped

handle inbound amnesia evidence correctly

add method to check if potential amnesia evidence is on trial

fix a bug with the height when we upgrade to amnesia evidence

change evidence to using just pointers.

More logging in the evidence module

Co-authored-by: Marko <marbar3778@yahoo.com>

Co-authored-by: JamesRay <66258875@qq.com>

making it possible to change app version via EndBlock

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

## Description

This pr removes amino from tendermint. 

Closes: #4278

Closes #1007

## Description

removing codec.go from p2p pkg and some leftover amino encoding

Closes: #XXX

Creates Amnesia Evidence which is formed from Potential Amnesia Evidence with either a matching proof or after a period of time denoted as the Amnesia Trial Period. This also adds the code necessary so that Amnesia Evidence can be validated and committed on a block

Closes #4763

* check for Error after for loop ends

so we don't silently ignore errors, which would lead to clients getting
incomplete results

Refs https://github.com/tendermint/tendermint/pull/4979/files#r436511572

## Description

the second part of state proto migration

Closes: #XXX

* proto: move mempool to proto

- changes according to moving the mempool reactor to proto

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

Closes: #2883