tendermint

Commit Graph

Author	SHA1	Message	Date
Alexander Simmerl	50ae892d5e	p2p: Keep reference to connections in test peer We observed non-deterministic test failures in one of our switch tests, which would happen if the GC would run between iterations of the accept loop. As we don't hold any reference to the connection the setup finalizer might get triggered and therefore the file handle closed. For the curious check the references on finalizers and the variable scoping in the spec: https://groups.google.com/forum/#!topic/golang-nuts/xWkhGJ5PY6c https://groups.google.com/forum/#!topic/golang-nuts/d8aF4rAob7U/discussion https://golang.org/ref/spec#Declarations_and_scope Fixes #1266	7 years ago
Ethan Buchman	9293ae76bf	p2p: introduce peerConn to simplify peer creation (#1226 ) * expose AuthEnc in the P2P config if AuthEnc is true, dialed peers must have a node ID in the address and it must match the persistent pubkey from the secret handshake. Refs #1157 * fixes after my own review * fix docs * fix build failure ``` p2p/pex/pex_reactor_test.go:288:88: cannot use seed.NodeInfo().NetAddress() (type p2p.NetAddress) as type string in array or slice literal ``` p2p: introduce peerConn to simplify peer creation * Introduce `peerConn` containing the known fields of `peer` * `peer` only created in `sw.addPeer` once handshake is complete and NodeInfo is checked * Eliminates some mutable variables and makes the code flow better * Simplifies the `newXxxPeer` funcs * Use ID instead of PubKey where possible. * SetPubKeyFilter -> SetIDFilter * nodeInfo.Validate takes ID * remove peer.PubKey() * persistent node ids * fixes from review * test: use ip_plus_id.sh more * fix invalid memory panic during fast_sync test ``` 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: panic: runtime error: invalid memory address or nil pointer dereference 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x98dd3e] 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: goroutine 3432 [running]: 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.newOutboundPeerConn(0xc423fd1380, 0xc420933e00, 0x1, 0x1239a60, 0 xc420128c40, 0x2, 0x42caf6, 0xc42001f300, 0xc422831d98, 0xc4227951c0, ...) 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/peer.go:123 +0x31e 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(Switch).addOutboundPeerWithConfig(0xc4200ad040, 0xc423fd1380, 0 xc420933e00, 0xc423f48801, 0x28, 0x2) 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:455 +0x12b 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(Switch).DialPeerWithAddress(0xc4200ad040, 0xc423fd1380, 0x1, 0x 0, 0x0) 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:371 +0xdc 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(Switch).reconnectToPeer(0xc4200ad040, 0x123e000, 0xc42007bb00) 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:290 +0x25f 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: created by github.com/tendermint/tendermint/p2p.(Switch).StopPeerForError 2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:256 +0x1b7 ```	7 years ago
Ethan Buchman	99034904f8	p2p: fix tests for required channels	7 years ago
Ethan Buchman	44e967184a	p2p: tmconn->conn and types->p2p	7 years ago
Ethan Buchman	5b5cbaa66a	p2p: use sub dirs	7 years ago
Ethan Buchman	f9e4f6eb6b	reorder peer.go methods	7 years ago
Ethan Buchman	8b74a8d6ac	NodeInfo not a pointer	7 years ago
Ethan Buchman	7667e11973	remove RemoteAddr from NodeInfo	7 years ago
Ethan Buchman	6e823c6e87	p2p: support addr format ID@IP:PORT	7 years ago
Ethan Buchman	528154f1a2	p2p: PrivKey need not be Ed25519	7 years ago
Anton Kaliaev	69b5da766c	service#Start, service#Stop signatures were changed See https://github.com/tendermint/tmlibs/issues/45	7 years ago
Zach Ramsay	15651a931e	linting errors: tackle p2p package	7 years ago
Zach Ramsay	46ccbcbff6	linting: apply 'gofmt -s -w' throughout	7 years ago
Ethan Buchman	aea8629272	peer interface	7 years ago
Ethan Buchman	e6cecb9595	p2p: fix test	7 years ago
Ethan Buchman	23a6a6f8fc	move into p2p package	8 years ago
Ethan Buchman	34965f610d	crypto Wrap/Unwrap	8 years ago
Anton Kaliaev	ebe23f1379	refactor MConnection#sendBytes	8 years ago
Anton Kaliaev	06d219db8e	test peer with no auth enc	8 years ago
Anton Kaliaev	1d01f6af98	2 kinds of peers: outbound and inbound	8 years ago
Anton Kaliaev	715b8c629f	use the peer struct to simulate remote peer	8 years ago
Anton Kaliaev	7dcc3dbcd1	test peer	8 years ago

16 Commits (315c475b791c9c48a35f52f79fef6afc2208138d)