tendermint

6359 Commits

183 Branches

291 MiB

Tree: 2aef80bcff

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Dev Ojha	c5c1689591	crypto/secp256k1: Add godocs, remove indirection in privkeys (#2017 ) * crypto/secp256k1: Add godocs, remove indirection in privkeys The following was previously done for creating secp256k1 private keys: First obtain privkey bytes. Then create a private key in the underlying library, with scalar exponent equal to privKeyBytes. (The method called was secp256k1.PrivKeyFromBytes, `fb90c334df/btcec/privkey.go (L21))` Then the private key was serialized using the underlying library, which just returns back the bytes that comprised the scalar exponent, but padded to be exactly 32 bytes. `fb90c334df/btcec/privkey.go (L70)` Thus the entire indirection of calling the underlying library can be avoided by just ensuring that we pass in a 32 byte value. A test case has even be written to show this more clearly in review. * crypto/secp256k1: Address PR comments Squash this commit * crypto: Remove note about re-registering amino paths when unnecessary. This commit should be squashed.	7 years ago
ValarDragon	c798702764	crypto: Remove Ed25519 and Secp256k1 suffix on GenPrivKey	7 years ago
ValarDragon	99e582d79a	crypto: Refactor to move files out of the top level directory Currently the top level directory contains basically all of the code for the crypto package. This PR moves the crypto code into submodules in a similar manner to what `golang/x/crypto` does. This improves code organization. Ref discussion: https://github.com/tendermint/tendermint/pull/1966 Closes #1956	7 years ago

Dev Ojha

c5c1689591

crypto/secp256k1: Add godocs, remove indirection in privkeys (#2017 )

* crypto/secp256k1: Add godocs, remove indirection in privkeys

The following was previously done for creating secp256k1 private keys:

First obtain privkey bytes. Then create a private key in the
underlying library, with scalar exponent equal to privKeyBytes.
(The method called was secp256k1.PrivKeyFromBytes,
fb90c334df/btcec/privkey.go (L21))

Then the private key was serialized using the underlying library, which just
returns back the bytes that comprised the scalar exponent, but padded to be
exactly 32 bytes.
fb90c334df/btcec/privkey.go (L70)

Thus the entire indirection of calling the underlying library can be avoided
by just ensuring that we pass in a 32 byte value. A test case has even be written
to show this more clearly in review.

* crypto/secp256k1: Address PR comments

Squash this commit

* crypto: Remove note about re-registering amino paths when unnecessary.

This commit should be squashed.

7 years ago

ValarDragon c798702764 crypto: Remove Ed25519 and Secp256k1 suffix on GenPrivKey 7 years ago

ValarDragon

99e582d79a

crypto: Refactor to move files out of the top level directory

Currently the top level directory contains basically all of the code
for the crypto package. This PR moves the crypto code into submodules
in a similar manner to what `golang/x/crypto` does. This improves code
organization.

Ref discussion: https://github.com/tendermint/tendermint/pull/1966

Closes #1956

7 years ago

3 Commits (2aef80bcff28b24fb959988c7a62b5b5db43ec33)