tendermint

Commit Graph

Author	SHA1	Message	Date
Sam Kleinman	28d34d635c	service: change stop interface (#7816 )	2 years ago
Callum Waters	e81b0e290e	spec: merge spec repo into tendermint repo (#7804 )	2 years ago
Sam Kleinman	824960c565	libs/service: regularize Stop semantics and concurrency primitives (#7809 )	2 years ago
Sam Kleinman	7a9a38d9d7	service: avoid debug logs before error (#7564 )	2 years ago
Sam Kleinman	2ff962a63a	log: dissallow nil loggers (#7445 )	2 years ago
Sam Kleinman	a62ac27047	service: remove exported logger from base implemenation (#7381 )	2 years ago
Sam Kleinman	a823d167bc	service: cleanup base implementation and some caller implementations (#7301 )	2 years ago
Sam Kleinman	7e58f02eb8	service: remove quit method (#7293 )	3 years ago
Sam Kleinman	6ab62fe7b6	service: remove stop method and use contexts (#7292 )	3 years ago
Sam Kleinman	d7606777cf	libs/service: pass logger explicitly (#7288 ) This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	3 years ago
Aleksandr Bezobchuk	3635c7a382	logger: refactor Tendermint logger by using zerolog (#6534 )	3 years ago
Sam Kleinman	663c0bba9c	rpc: decouple test fixtures from node implementation (#6533 )	3 years ago
Marko	45572117ae	logging: print string instead of callback (#6177 ) ## Description Fixes marshaling error in sdk closes https://github.com/cosmos/cosmos-sdk/issues/8578 the output stays the same, we are avoiding the passing of the callback because sdk uses typed logging.	3 years ago
Erik Grinaker	66b0ec0af1	clarify service logging The service logging can be a bit unclear. For example, with state sync it would log: ``` I[2020-04-20\|08:40:47.366] Starting StateSync module=statesync impl=Reactor I[2020-04-20\|08:40:47.834] Starting state sync module=statesync ``` Where the first message is the reactor service startup, and the second message is the start of the actual state sync process. This clarifies the first message by changing it to `Starting StateSync service`. ______ For contributor use: - [ ] ~Wrote tests~ - [ ] ~Updated CHANGELOG_PENDING.md~ - [ ] ~Linked to Github issue with discussion and accepted design OR link to spec that describes this work.~ - [ ] ~Updated relevant documentation (`docs/`) and code comments~ - [x] Re-reviewed `Files changed` in the Github PR explorer	4 years ago
Marko	27b00cf8d1	libs/common: refactor libs common 3 (#4232 ) * libs/common: refactor libs common 3 - move nil.go into types folder and make private - move service & baseservice out of common into service pkg ref #4147 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add changelog entry	4 years ago
Thane Thomson	70592cc4d8	libs/common: remove deprecated PanicXXX functions (#3595 ) * Remove deprecated PanicXXX functions from codebase As per discussion over [here](https://github.com/tendermint/tendermint/pull/3456#discussion_r278423492), we need to remove these `PanicXXX` functions and eliminate our dependence on them. In this PR, each and every `PanicXXX` function call is replaced with a simple `panic` call. * add a changelog entry	5 years ago
tracebundy	660bd4a53e	fix comment (#3454 )	5 years ago
Anton Kaliaev	e3e3c13741	[common] revert started flag when service already stopped (#2326 ) also, return ErrNotStarted when trying to stop a not-running service	6 years ago
Dev Ojha	2756be5a59	libs: Remove usage of custom Fmt, in favor of fmt.Sprintf (#2199 ) * libs: Remove usage of custom Fmt, in favor of fmt.Sprintf Closes #2193 * Fix bug that was masked by custom Fmt!	6 years ago
Zach Ramsay	44dad6d70b	Revert "detele everything" This reverts commit `d02c5d1e30`.	6 years ago
Zach Ramsay	d02c5d1e30	detele everything	6 years ago
Ethan Buchman	d55243f0e6	fix import paths	6 years ago
Ethan Buchman	ae3bf81833	mv tmlibs files to libs dir	6 years ago
Thomas Corbière	ee67e34519	Fix lint errors (#190 ) * use increment and decrement operators. * remove unnecessary else branches. * fix receiver names. * remove omittable code. * fix dot imports.	6 years ago
Anton Kaliaev	a57340ffb5	add Quit method to Service interface remove deprecated QuitService	6 years ago
Ethan Buchman	4d991acae0	common: comments for Service	7 years ago
Anton Kaliaev	c2fcc093b2	remove bool from Service#Reset	7 years ago
Anton Kaliaev	e6164d4052	change service#Stop to be similar to Start	7 years ago
Anton Kaliaev	4123d54bf6	change service#Start to return just error (Refs #45 ) ``` @melekes yeah, bool is superfluous @ethanfrey If I remember correctly when I was writing test code, if I call Start() on a Service that is already running, it returns (false, nil). Only if I try to legitimately start it, but it fails in startup do I get an error. The distinction is quite important to make it safe for reentrant calls. The other approach would be to have a special error type like ErrAlreadyStarted, then check for that in your code explicitly. Kind of like if I make a db call in gorm, and get an error, I check if it is a RecordNotFound error, or whether there was a real error with the db query. @melekes Ah, I see. Thanks. I must say I like ErrAlreadyStarted approach more (not just in Golang) ```	7 years ago
Ethan Buchman	c8805fd7de	metalinter fixes from review	7 years ago
Zach Ramsay	cf49ba876f	linter: couple fixes	7 years ago
Zach Ramsay	3c57c24921	linting: next round of fixes	7 years ago
Anton Kaliaev	ed76afd409	Logger interface and tmLogger impl based on go-kit	7 years ago
Ethan Buchman	356657a37b	move all files to common/ to begin repo merge	7 years ago
Anton Kaliaev	dec518eb06	update comment [ci skip] [circleci skip]	7 years ago
Anton Kaliaev	7a12594edb	[service] recreate Quit channel on reset don't think that user should do this thing him/herself	7 years ago
Anton Kaliaev	c46ffe39a8	[service] check for error returned by impl otherwise, we mark it as started when it is not in fact	7 years ago
Ethan Buchman	a552e49b50	Reverts commit f40b1b to a6a67e	8 years ago
Jae Kwon	890e240730	Remove AutoFile tests	8 years ago
Jae Kwon	25dc9ae345	QuitService->BaseService	8 years ago
Jae Kwon	fa3daa7abc	Remove AutoFile tests	8 years ago
Jae Kwon	2781df39e5	QuitService->BaseService	8 years ago
Ethan Buchman	2e424ee663	service: Reset() for restarts	8 years ago
Ethan Buchman	9364accf1f	service: start/stop logs are info, ignored are debug	8 years ago
Ethan Buchman	02022e356a	make ignore already stopped service Debug	8 years ago
Jae Kwon	19f5a93cff	Adjust Service log notice for duplicate stops	8 years ago
Jae Kwon	6b54e7b8d9	Added License	9 years ago
Jae Kwon	16372365c4	First commit	9 years ago

14 Commits (28d34d635c0dcbfd862d5ce393aba07ae60bf2a4)