Ethan Buchman
4d991acae0
common: comments for Service
7 years ago
Ethan Buchman
ddd141c1c5
Merge branch 'develop' into 45-change-common-start-signature
7 years ago
Ethan Buchman
57fea1335a
Makefile and linter
7 years ago
Anton Kaliaev
c2fcc093b2
remove bool from Service#Reset
7 years ago
Anton Kaliaev
f75339264f
Merge pull request #83 from tendermint/gut-process
remove package process
7 years ago
Emmanuel Odeke
e07ad01f62
remove package process
Fixes https://github.com/tendermint/tmlibs/issues/81
That package is untested and racy, and not used except in
a test, but even that's now gutted with
https://github.com/tendermint/abci/pull/139
so the general consensus is that we sunset this package.
7 years ago
Anton Kaliaev
eb31c04f47
Merge tag 'v0.4.1' into develop
Tagged 0.4.1 release
7 years ago
Anton Kaliaev
b854baa1fc
Merge branch 'release/0.4.1'
7 years ago
Anton Kaliaev
3244f73f32
update version
7 years ago
Anton Kaliaev
4e705a3157
update changelog
7 years ago
Ethan Buchman
d3bac7a6fe
clist: reduce numTimes in test
7 years ago
Ethan Buchman
135a1a7cd7
db: sort keys for memdb iterator
7 years ago
Jae Kwon
56e51bc113
CacheWrap() -> CacheDB() CacheDB
7 years ago
Anton Kaliaev
2442a0a698
Merge pull request #78 from tendermint/editorconfig
add .editorconfig
7 years ago
Anton Kaliaev
4ea6340f1a
add .editorconfig
7 years ago
Jae Kwon
8481c49c82
CacheDB ( #67 )
* Add CacheDB & SimpleMap
* Generic memBatch; Fix cLevelDB tests
* CacheWrap() for CacheDB and MemDB
* Change Iterator to match LeviGo Iterator
* Fixes from review
* cacheWrapWriteMutex and some race fixes
* Use tmlibs/common
* NewCWWMutex is exposed. DB can be CacheWrap'd
* Remove GetOK, not needed
* Fsdb (#72 )
* Add FSDB
* Review fixes from Anton
* Review changes
* Fixes from review
7 years ago
Anton Kaliaev
176c2ceed6
Merge pull request #77 from tendermint/18-unsupported-value-type
encode complex types as "%+v"
7 years ago
Anton Kaliaev
798848320f
Merge pull request #76 from tendermint/29-log-logger-errors
log logger's errors
7 years ago
Anton Kaliaev
69447564b8
encode complex types as "%+v" (Refs #18 )
7 years ago
Anton Kaliaev
4b989151ed
log logger's errors (Refs #29 )
7 years ago
Anton Kaliaev
e6164d4052
change service#Stop to be similar to Start
7 years ago
Anton Kaliaev
4123d54bf6
change service#Start to return just error (Refs #45 )
```
@melekes
yeah, bool is superfluous
@ethanfrey
If I remember correctly when I was writing test code, if I call Start() on a Service that is already running, it returns (false, nil). Only if I try to legitimately start it, but it fails in startup do I get an error.
The distinction is quite important to make it safe for reentrant calls. The other approach would be to have a special error type like ErrAlreadyStarted, then check for that in your code explicitly. Kind of like if I make a db call in gorm, and get an error, I check if it is a RecordNotFound error, or whether there was a real error with the db query.
@melekes
Ah, I see. Thanks. I must say I like ErrAlreadyStarted approach more (not just in Golang)
```
7 years ago
Anton Kaliaev
ac0cf0b2e2
Merge pull request #74 from tendermint/73-undefined-syscall-kill
use os.Process#Kill (Fixes #73 )
7 years ago
Anton Kaliaev
49d75e223e
use os.Process#Kill ( Fixes #73 )
7 years ago
Anton Kaliaev
b658294a13
use assert.Contains in cmap_test
7 years ago
Wolf
88481fc363
Make iterating over keys possible ( #63 )
* Make iterating over keys possible
* add test for cmap
- test Keys() and Values() respectively
* one cmap per test-case
7 years ago
Anton Kaliaev
0f555f8d2c
Merge pull request #71 from tendermint/69-read-impl-and-tests
[autofile] test GroupReader more extensively (Refs #69 )
7 years ago
Anton Kaliaev
d8dd497069
fix metalinter errors
7 years ago
Anton Kaliaev
668698584d
[autofile] test GroupReader more extensively (Refs #69 )
7 years ago
Ethan Buchman
d9525c0fb6
Merge pull request #70 from tendermint/develop
Develop
7 years ago
Ethan Buchman
b14c996698
update changelog
7 years ago
Ethan Buchman
092eb701c7
cmn: Kill
7 years ago
Ethan Buchman
42145a82bd
version and changelog
7 years ago
Ethan Buchman
b30e3ba26d
Merge pull request #65 from tendermint/573-wal-issues-2
[autofile] Support for the new WAL format
7 years ago
Anton Kaliaev
0a652499ea
Merge pull request #68 from tendermint/bugfix/gopath-executes-go
make GoPath a function
7 years ago
Anton Kaliaev
bcf15e527d
make GoPath a function
otherwise it could try to execute go binary and panic if no go binary
found. See https://github.com/tendermint/tendermint/issues/782
7 years ago
Ethan Buchman
93bd2081dd
Merge pull request #66 from tendermint/codecov
add codecov
7 years ago
Anton Kaliaev
f99c73502c
add codecov
7 years ago
Anton Kaliaev
103fee6192
add tests for autofile group Write, reader#Read
7 years ago
Anton Kaliaev
81591e288e
fix metalinter warnings
7 years ago
Anton Kaliaev
d4c6a68e58
Merge pull request #64 from silasdavis/event-cache
Fix zeroed buffer getting flushed to the empty event
7 years ago
Silas Davis
0eff425bc7
fix zeroed buffer getting flushed to the empty event
7 years ago
Anton Kaliaev
21b2c26fb1
GroupReader#Read: return io.EOF if file is empty
7 years ago
Anton Kaliaev
c75ddd0fa3
return err if empty slice given
7 years ago
Anton Kaliaev
35e81018e9
add MinIndex method to Group
7 years ago
Anton Kaliaev
aace56018a
add Read method to GroupReader
7 years ago
Anton Kaliaev
45095e83e7
add Write method to autofile/Group
7 years ago
Anton Kaliaev
498fb1134a
write docs for autofile/group
7 years ago
Anton Kaliaev
8e5266a9ef
Merge pull request #62 from tendermint/tests-fix
fix goLevelDBIterator
7 years ago
Anton Kaliaev
1f15ade60d
Merge pull request #61 from tendermint/60-cmn-gopath-needs-a-default
call go env GOPATH if env var is not found (Refs #60 )
7 years ago