tendermint

Commit Graph

Author	SHA1	Message	Date
Dev Ojha	dae7dc30e0	Switch usage of math/rand to cmn's rand (#1980 ) This commit switches all usage of math/rand to cmn's rand. The only exceptions are within the random file itself, the tools package, and the crypto package. In tools you don't want it to lock between the go-routines. The crypto package doesn't use it so the crypto package have no other dependencies within tendermint/tendermint for easier portability. Crypto/rand usage is unadjusted. Closes #1343	6 years ago
Ethan Buchman	d903057011	fix stopping pubsub	6 years ago
Anton Kaliaev	6a85aecfb7	fix linter issues	6 years ago
Anton Kaliaev	e4db5f8dcd	test event bus Refs #693	6 years ago
Zach Ramsay	44dad6d70b	Revert "detele everything" This reverts commit `d02c5d1e30`.	6 years ago
Zach Ramsay	d02c5d1e30	detele everything	6 years ago
Zach	030c782e6f	Zach/1793 repo consolidation v2 (#1907 )	6 years ago
Zach Ramsay	5fb3955c93	cleanup repo merge artifacts, closes #1873 , starts #1793	6 years ago
Zach	489f2525bd	Delete libs/common/array.go closes https://github.com/tendermint/tmlibs/issues/133	6 years ago
Ethan Buchman	ca3e337ef9	remove libs/merkle	6 years ago
Ethan Buchman	eccdce11c5	make linter happy	6 years ago
Ethan Buchman	3f4847331f	update grpc version. fix remotedb tests	6 years ago
Ethan Buchman	ff73e0aa55	fix test folder mishap	6 years ago
Ethan Buchman	d55243f0e6	fix import paths	6 years ago
Ethan Buchman	ae3bf81833	mv tmlibs files to libs dir	6 years ago
Jae Kwon	bf0ff212b9	Refactor "lite" to handle delayed validator set changes. Also, fix consensus liveness issue.	7 years ago
Liamsi	d2c05bc5b9	Revert "delete everything" (includes everything non-go-crypto) This reverts commit `96a3502`	6 years ago
Liamsi	96a3502126	delete everything	6 years ago
Anton Kaliaev	4fc06e9d2a	[libs/pubsub] fix memory leak Refs #1755 I started with writing a test for wsConnection (WebsocketManager) where I: - create a WS connection - do a simple echo call - close it No leaking goroutines, nor any leaking memory were detected. For useful shortcuts see my blog post https://blog.cosmos.network/debugging-the-memory-leak-in-tendermint-210186711420 Then I went to the rpc tests to see if calling Subscribe results in memory growth. It did. I used a slightly modified version of TestHeaderEvents function: ``` func TestHeaderEvents(t testing.T) { // memory heap before f, err := os.Create("/tmp/mem1.mprof") if err != nil { t.Fatal(err) } pprof.WriteHeapProfile(f) f.Close() for i := 0; i < 100; i++ { c := getHTTPClient() err = c.Start() require.Nil(t, err) evtTyp := types.EventNewBlockHeader evt, err := client.WaitForOneEvent(c, evtTyp, waitForEventTimeout) require.Nil(t, err) _, ok := evt.(types.EventDataNewBlockHeader) require.True(t, ok) c.Stop() c = nil } runtime.GC() // memory heap before f, err = os.Create("/tmp/mem2.mprof") if err != nil { t.Fatal(err) } pprof.WriteHeapProfile(f) f.Close() // dump all running goroutines time.Sleep(10 time.Second) pprof.Lookup("goroutine").WriteTo(os.Stdout, 1) } ``` ``` Showing nodes accounting for 35159.16kB, 100% of 35159.16kB total Showing top 10 nodes out of 48 flat flat% sum% cum cum% 32022.23kB 91.08% 91.08% 32022.23kB 91.08% github.com/tendermint/tendermint/libs/pubsub/query.(QueryParser).Init 1056.33kB 3.00% 94.08% 1056.33kB 3.00% bufio.NewReaderSize 528.17kB 1.50% 95.58% 528.17kB 1.50% bufio.NewWriterSize 528.17kB 1.50% 97.09% 528.17kB 1.50% github.com/tendermint/tendermint/consensus.NewConsensusState 512.19kB 1.46% 98.54% 512.19kB 1.46% runtime.malg 512.08kB 1.46% 100% 512.08kB 1.46% syscall.ByteSliceFromString 0 0% 100% 512.08kB 1.46% github.com/tendermint/tendermint/consensus.(ConsensusState).(github.com/tendermint/tendermint/consensus.defaultDecideProposal)-fm 0 0% 100% 512.08kB 1.46% github.com/tendermint/tendermint/consensus.(ConsensusState).addVote 0 0% 100% 512.08kB 1.46% github.com/tendermint/tendermint/consensus.(ConsensusState).defaultDecideProposal 0 0% 100% 512.08kB 1.46% github.com/tendermint/tendermint/consensus.(ConsensusState).enterNewRound ``` 100 subscriptions produce 32MB. Again, no additional goroutines are running after the end of the test (wsConnection readRoutine and writeRoutine both finishes). It means that some exiting goroutine or object is holding a reference to the Query objects, which are leaking.** One of them is pubsub#loop. It's using state.queries to map queries to clients and state.clients to map clients to queries. Before this commit, we're not thoroughly cleaning state.queries, which was the reason for memory leakage.	7 years ago
Anton Kaliaev	6004587347	expect all tags to be strings (#1498 ) * expect all tags to be strings Refs #1369 * port changes from https://github.com/tendermint/tmlibs/pull/204 Refs #1369	7 years ago
Anton Kaliaev	c6f612bfc3	subscribe before state emits NewRoundStep I had to alter events package for that. Hope that's fine. Refs #847	7 years ago
Anton Kaliaev	bb9aa85d22	copy events and pubsub packages from tmlibs Refs #847	7 years ago

1 2 3 4

173 Commits (2544a5cf3a2b2e5dd90c6b15c23bcb82b9b23a31)