tendermint

9323 Commits

183 Branches

291 MiB

Tree: 070445bc10

Commit Graph

Author	SHA1	Message	Date
Sam Kleinman	6ab62fe7b6	service: remove stop method and use contexts (#7292 )	3 years ago
Sam Kleinman	d7606777cf	libs/service: pass logger explicitly (#7288 ) This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	3 years ago
Sam Kleinman	a855f96946	p2p: renames for reactors and routing layer internal moves (#6547 )	4 years ago

Author

SHA1

Message

Date

Sam Kleinman

6ab62fe7b6

service: remove stop method and use contexts (#7292 )

3 years ago

Sam Kleinman

d7606777cf

libs/service: pass logger explicitly (#7288 )

This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.

The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.

3 years ago

Sam Kleinman

a855f96946

p2p: renames for reactors and routing layer internal moves (#6547 )

4 years ago

3 Commits (070445bc1088a8cf08bace8080a4549e93dff5a3)