tendermint

Commit Graph

Author	SHA1	Message	Date
Emmanuel Odeke	15ef57c6d0	types: TxEventBuffer.Flush now uses capacity preserving slice clearing idiom Fixes https://github.com/tendermint/tendermint/issues/1189 For every TxEventBuffer.Flush() invoking, we were invoking a: b.events = make([]EventDataTx, 0, b.capacity) whose intention is to innocently clear the events slice but maintain the underlying capacity. However, unfortunately this is memory and garbage collection intensive which is linear in the number of events added. If an attack had access to our code somehow, invoking .Flush() in tight loops would be a sure way to cause huge GC pressure, and say if they added about 1e9 events maliciously, every Flush() would take at least 3.2seconds which is enough to now control our application. The new using of the capacity preserving slice clearing idiom takes a constant time regardless of the number of elements with zero allocations so we are killing many birds with one stone i.e b.events = b.events[:0] For benchmarking results, please see https://gist.github.com/odeke-em/532c14ab67d71c9c0b95518a7a526058 for a reference on how things can get out of hand easily.	7 years ago
Luke Schoen	f37c502fd8	Update getting-started.rst with Python 3 example	7 years ago
Anton Kaliaev	945b0e6eca	cleanup glide.yaml	7 years ago
Anton Kaliaev	84a0a1987c	comment out tests for now https://github.com/tendermint/tendermint/pull/1173#issuecomment-363173047	7 years ago
Anton Kaliaev	11b68f1934	rewrite broadcastTxRoutine to use channels https://play.golang.org/p/gN21yO9IRs3 ``` func waitWithCancel(f func() clist.CElement, ctx context.Context) clist.CElement { el := make(chan *clist.CElement, 1) select { case el <- f(): ``` will just run f() blockingly, so this doesn't change much in terms of behavior.	7 years ago
Anton Kaliaev	202d9a2c0c	fix memory leak in mempool reactor Leaking goroutine: ``` 114 @ 0x42f2bc 0x42f3ae 0x440794 0x4403b9 0x468002 0x9fe32d 0x9ff78f 0xa025ed 0x45e571 ``` Explanation: it blocks on an empty clist forever. so unless theres txs coming in, this go routine will just sit there, holding onto the peer too. if we're constantly reconnecting to some peer, old instances are not garbage collected, leading to memory leak. Fixes https://github.com/cosmos/gaia/issues/108 Previous attempt https://github.com/tendermint/tendermint/pull/1156	7 years ago
Ethan Buchman	bf84e82577	Merge pull request #1184 from tendermint/sdk2-tmlibs-abci Updates for tmlibs and abci (sdk2)	7 years ago
Ethan Buchman	abca9a2d61	woops - bring back glide.lock file	7 years ago
Ethan Buchman	d34286c421	minor fixes - tests pass	7 years ago
Anton Kaliaev	bb2bdbc0e1	add missing element (tag.Value) to keyForTag encoded as %s. not sure this will work with raw bytes	7 years ago
Ethan Buchman	e7747f7d66	it compiles	7 years ago
Ethan Buchman	7a5060dc52	replace data.Bytes with cmn.HexBytes	7 years ago
Ethan Buchman	426379dc47	remove use of wire/nowriter	7 years ago
Ethan Buchman	cd0fd06b0d	update for sdk2 libs. need to fix kv test NOTE we only updating for tmlibs and abci	7 years ago
Ethan Buchman	4e3488c677	update types	7 years ago
Ethan Buchman	061ad355bb	update glide	7 years ago
Ethan Buchman	2679b7554b	lite: comment out iavl code - TODO #1183	7 years ago
Ethan Buchman	62c9cad484	Merge pull request #1180 from tendermint/1146-add-BFT-time-spec Add BFT time spec	7 years ago
Zarko Milosevic	4cbdbbaac9	Add BFT time spec	7 years ago
Ethan Buchman	2919bc3f7f	Merge pull request #1178 from tendermint/nice-err-msg improve error message	7 years ago
Zach Ramsay	1c01671ec6	improve vague error msg, closes #1158	7 years ago
Ethan Buchman	fe632ea32a	spec: minor fixes	7 years ago
Zach Ramsay	5b368252ac	spec: more fixes	7 years ago
Zach Ramsay	8cca953590	spec: remove notes, see #1152	7 years ago
Zach Ramsay	4b4a2029c4	spec: typos & other fixes	7 years ago
Ethan Buchman	6aa85357b6	Merge pull request #1160 from shapeshed/patch-1 Fix documentation typos	7 years ago
Ethan Buchman	eae62ec09b	Merge branch 'develop' into patch-1	7 years ago
Ethan Buchman	18d96266bc	Merge pull request #1140 from tendermint/feature/vagrant Fix Vagrantfile	7 years ago
George Ornbo	4529fd6787	Fix documentation typos	7 years ago
Ethan Buchman	4a99a2a07d	update contributing.md	7 years ago
Adrian Brink	4b63b3aa0b	Switch to correct directory in Vagrant	7 years ago
Adrian Brink	fc860c3a07	Final Vagrantfile	7 years ago
Adrian Brink	2f147ec000	Remove upgrade step	7 years ago
Adrian Brink	0a7a190cd1	Fix vagrantfile If you get an error, please run `vagrant box update`.	7 years ago
Ethan Buchman	3366dfe32a	Merge pull request #1151 from tendermint/fix/p2p-stop-conn p2p/conn: fix blocking on pong during quit and break out of loops	7 years ago
Ethan Buchman	baff4bd8cc	p2p/conn: better handling for some stop conditions	7 years ago
Ethan Buchman	fb109db33d	update changelog	7 years ago
Ethan Buchman	2f5971532e	Merge pull request #1154 from tendermint/fix/consensus-tests consensus: fix SetLogger in tests	7 years ago
Ethan Buchman	ab13806276	consensus: print go routines in failed test	7 years ago
Ethan Buchman	3ae26bd6e6	consensus: fix SetLogger in tests	7 years ago
Ethan Buchman	27ef3489a0	Merge pull request #1049 from tendermint/p2p-channels p2p: add Channels to NodeInfo and don't send for unknown channels	7 years ago
Ethan Buchman	b6eb275b22	p2p: fix break in double loop	7 years ago
Ethan Buchman	57cc8ab977	Merge pull request #1143 from tendermint/1091-race-condition call FlushSync before calling CommitSync	7 years ago
Ethan Buchman	99034904f8	p2p: fix tests for required channels	7 years ago
Ethan Buchman	a0ffcbcee4	Merge pull request #1137 from tendermint/docs-consolidate WIP: docs consolidation	7 years ago
Ethan Buchman	260affd037	docs consolidation	7 years ago
Ethan Buchman	d7b1b8d3d5	Merge pull request #1129 from tendermint/addrbook p2p: bust up into sub dirs	7 years ago
Ethan Buchman	50129ad8ac	p2p: add Channels to NodeInfo and don't send for unknown channels	7 years ago
Ethan Buchman	5c9cb5e6a2	Merge pull request #1133 from tendermint/fix/stop-peer-for-error StopPeerForError in blockchain and consensus	7 years ago
Ethan Buchman	4051391039	blockchain: test wip for hard to test functionality [ci skip]	7 years ago

1 2 3 4 5 ...

3282 Commits (0467de890a2f488090ca43b7353b2eb89dd23fd7) All Branches Search

3282 Commits (0467de890a2f488090ca43b7353b2eb89dd23fd7)

All Branches