From f61e6e42015a55650e545c672194ce1b45260725 Mon Sep 17 00:00:00 2001 From: Sam Kleinman Date: Fri, 18 Mar 2022 12:05:53 -0400 Subject: [PATCH] autofile: remove vestigal close mechanism (#8150) --- internal/libs/autofile/group.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/internal/libs/autofile/group.go b/internal/libs/autofile/group.go index 0d1806f22..81e16feea 100644 --- a/internal/libs/autofile/group.go +++ b/internal/libs/autofile/group.go @@ -69,11 +69,6 @@ type Group struct { minIndex int // Includes head maxIndex int // Includes head, where Head will move to - // close this when the processTicks routine is done. - // this ensures we can cleanup the dir after calling Stop - // and the routine won't be trying to access it anymore - doneProcessTicks chan struct{} - // TODO: When we start deleting files, we need to start tracking GroupReaders // and their dependencies. } @@ -101,7 +96,6 @@ func OpenGroup(ctx context.Context, logger log.Logger, headPath string, groupOpt groupCheckDuration: defaultGroupCheckDuration, minIndex: 0, maxIndex: 0, - doneProcessTicks: make(chan struct{}), } for _, option := range groupOptions { @@ -154,13 +148,6 @@ func (g *Group) OnStop() { } } -// Wait blocks until all internal goroutines are finished. Supposed to be -// called after Stop. -func (g *Group) Wait() { - // wait for processTicks routine to finish - <-g.doneProcessTicks -} - // Close closes the head file. The group must be stopped by this moment. func (g *Group) Close() { if err := g.FlushAndSync(); err != nil { @@ -241,8 +228,6 @@ func (g *Group) FlushAndSync() error { } func (g *Group) processTicks(ctx context.Context) { - defer close(g.doneProcessTicks) - for { select { case <-ctx.Done():