Browse Source

rename HasVote to ReceivedVote (#289)

pull/7804/head
Yixin Luo 4 years ago
committed by GitHub
parent
commit
f3216e6953
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
  1. +3
    -3
      proto/consensus/types.proto
  2. +1
    -1
      spec/consensus/consensus.md
  3. +3
    -3
      spec/p2p/messages/consensus.md

+ 3
- 3
proto/consensus/types.proto View File

@ -52,8 +52,8 @@ message Vote {
tendermint.types.Vote vote = 1; tendermint.types.Vote vote = 1;
} }
// HasVote is sent to indicate that a particular vote has been received.
message HasVote {
// ReceivedVote is sent to indicate that a particular vote has been received.
message ReceivedVote {
uint64 height = 1; uint64 height = 1;
int32 round = 2; int32 round = 2;
tendermint.types.SignedMsgType type = 3; tendermint.types.SignedMsgType type = 3;
@ -85,7 +85,7 @@ message Message {
ProposalPOL proposal_pol = 4; ProposalPOL proposal_pol = 4;
BlockPart block_part = 5; BlockPart block_part = 5;
Vote vote = 6; Vote vote = 6;
HasVote has_vote = 7;
ReceivedVote received_vote = 7;
VoteSetMaj23 vote_set_maj23 = 8; VoteSetMaj23 vote_set_maj23 = 8;
VoteSetBits vote_set_bits = 9; VoteSetBits vote_set_bits = 9;
} }


+ 1
- 1
spec/consensus/consensus.md View File

@ -110,7 +110,7 @@ example,
- Nodes gossip to nodes lagging in blockchain height with block - Nodes gossip to nodes lagging in blockchain height with block
[commits](https://godoc.org/github.com/tendermint/tendermint/types#Commit) [commits](https://godoc.org/github.com/tendermint/tendermint/types#Commit)
for older blocks. for older blocks.
- Nodes opportunistically gossip `HasVote` messages to hint peers what
- Nodes opportunistically gossip `ReceivedVote` messages to hint peers what
votes it already has. votes it already has.
- Nodes broadcast their current state to all neighboring peers. (but - Nodes broadcast their current state to all neighboring peers. (but
is not gossiped further) is not gossiped further)


+ 3
- 3
spec/p2p/messages/consensus.md View File

@ -95,9 +95,9 @@ and what prevotes for the re-proposed block the process has.
| proposal_pol_round | int32 | | 2 | | proposal_pol_round | int32 | | 2 |
| proposal_pol | bitarray | | 3 | | proposal_pol | bitarray | | 3 |
### HasVote
### ReceivedVote
HasVote is sent to indicate that a particular vote has been received. It contains height,
ReceivedVote is sent to indicate that a particular vote has been received. It contains height,
round, vote type and the index of the validator that is the originator of the corresponding vote. round, vote type and the index of the validator that is the originator of the corresponding vote.
| Name | Type | Description | Field Number | | Name | Type | Description | Field Number |
@ -144,6 +144,6 @@ Message is a [`oneof` protobuf type](https://developers.google.com/protocol-buff
| proposal_pol | [ProposalPOL](#proposalpol) | | 4 | | proposal_pol | [ProposalPOL](#proposalpol) | | 4 |
| block_part | [BlockPart](#blockpart) | | 5 | | block_part | [BlockPart](#blockpart) | | 5 |
| vote | [Vote](#vote) | | 6 | | vote | [Vote](#vote) | | 6 |
| has_vote | [HasVote](#hasvote) | | 7 |
| received_vote | [ReceivedVote](#ReceivedVote) | | 7 |
| vote_set_maj23 | [VoteSetMaj23](#votesetmaj23) | | 8 | | vote_set_maj23 | [VoteSetMaj23](#votesetmaj23) | | 8 |
| vote_set_bits | [VoteSetBits](#votesetbits) | | 9 | | vote_set_bits | [VoteSetBits](#votesetbits) | | 9 |

Loading…
Cancel
Save