From f2aa1bf50e3eb61f9cf27ee4e867fbd1daf9069f Mon Sep 17 00:00:00 2001
From: kevlubkcm <36485490+kevlubkcm@users.noreply.github.com>
Date: Wed, 17 Apr 2019 12:14:01 -0400
Subject: [PATCH] bandaid for non-deterministic clist test (#3575)

* add a deterministic timeout

Co-Authored-By: kevlubkcm <36485490+kevlubkcm@users.noreply.github.com>
---
 libs/clist/clist_test.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libs/clist/clist_test.go b/libs/clist/clist_test.go
index 13aca3577..1784f8218 100644
--- a/libs/clist/clist_test.go
+++ b/libs/clist/clist_test.go
@@ -261,6 +261,8 @@ func TestWaitChan(t *testing.T) {
 			pushed++
 			time.Sleep(time.Duration(cmn.RandIntn(25)) * time.Millisecond)
 		}
+		// apply a deterministic pause so the counter has time to catch up
+		time.Sleep(25 * time.Millisecond)
 		close(done)
 	}()
 
@@ -273,7 +275,7 @@ FOR_LOOP:
 			next = next.Next()
 			seen++
 			if next == nil {
-				continue
+				t.Fatal("Next should not be nil when waiting on NextWaitChan")
 			}
 		case <-done:
 			break FOR_LOOP