Browse Source
adr: crypto encoding for proto (#4481)
* adr: crypto encoding for proto work - this adr is meant to help with deciding on how to move forward with keys in tendermint. * minor change * fix gomod * add a third option * fix spelling * add first part of descision * breakdown keys and where they are used * add some wording * minor wording fix * question * change proto messages * minor update * undo go.mod changes * add a few things based on comemnts * push, push it real good * minor explanation on interface type * touch uppull/4481/merge
Marko
5 years ago
committed by
GitHub
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 97 additions and 7 deletions
Split View
Diff Options
-
+2 -0docs/architecture/README.md
-
+83 -0docs/architecture/adr-054-crypto-encoding-2.md
-
+9 -7docs/architecture/adr-template.md
-
+3 -0go.sum
+ 2
- 0
docs/architecture/README.md
View File
+ 83
- 0
docs/architecture/adr-054-crypto-encoding-2.md
View File
| @ -0,0 +1,83 @@ | |||
| # ADR 054: Crypto encoding (part 2) | |||
| ## Changelog | |||
| \*2020-2-27: Created | |||
| ## Context | |||
| Amino has been a pain point of many users in the ecosystem. While Tendermint does not suffer greatly from the performance degradation introduced by amino, we are making an effort in moving the encoding format to a widely adopted format, [Protocol Buffers](https://developers.google.com/protocol-buffers). With this migration a new standard is needed for the encoding of keys. This will cause ecosystem wide breaking changes. | |||
| Currently amino encodes keys as `<PrefixBytes> <Length> <ByteArray>`. | |||
| ## Decision | |||
| When using the `oneof` protobuf type there are many times where one will have to manually switch over the possible messages and then pass them to the interface which is needed. By transitioning from a fixed size byte array (`[size]byte`) to byte slice's (`[]byte`) then this would enable the usage of the [cosmos-proto's](hhttps://github.com/regen-network/cosmos-proto#interface_type) interface type, which will generate these switch statements. | |||
| The approach that will be taken to minimize headaches for users is one where all encoding of keys will shift to protobuf and where amino encoding is relied on, there will be custom marshal and unmarshal functions. | |||
| Protobuf messages: | |||
| ```proto | |||
| message PubKey { | |||
| option (cosmos_proto.interface_type) = "*github.com/tendermint/tendermint/crypto.PubKey"; | |||
| oneof key { | |||
| bytes ed25519 = 1 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/ed25519.PubKey"]; | |||
| bytes secp256k1 = 2 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/secp256k1.PubKey"]; | |||
| bytes sr25519 = 3 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/sr25519.PubKey"]; | |||
| PubKeyMultiSigThreshold multisig = 4 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/multisig.PubKeyMultisigThreshold"];; | |||
| } | |||
| message PrivKey { | |||
| option (cosmos_proto.interface_type) = "github.com/tendermint/tendermint/crypto.PrivKey"; | |||
| oneof sum { | |||
| bytes ed25519 = 1 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/ed25519.PrivKey"]; | |||
| bytes secp256k1 = 2 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/secp256k1.PrivKey"]; | |||
| bytes sr25519 = 3 | |||
| [(gogoproto.casttype) = "github.com/tendermint/tendermint/crypto/sr25519.PrivKey"];; | |||
| } | |||
| } | |||
| ``` | |||
| > Note: The places where backwards compatibility is needed is still unclear. | |||
| All modules currently do not rely on amino encoded bytes and keys are not amino encoded for genesis, therefore a hardfork upgrade is what will be needed to adopt these changes. | |||
| This work will be broken out into a few PRs, this work will be merged into a proto-breakage branch, all PRs will be reviewed prior to being merged: | |||
| 1. Encoding of keys to protobuf and protobuf messages | |||
| 2. Move Tendermint types to protobuf, mainly the ones that are being encoded. | |||
| 3. Go one by one through the reactors and transition amino encoded messages to protobuf. | |||
| 4. Test with cosmos-sdk and/or testnets repo. | |||
| ## Status | |||
| Proposed | |||
| ## Consequences | |||
| - Move keys to protobuf encoding, where backwards compatibility is needed, amino marshal and unmarshal functions will be used. | |||
| ### Positive | |||
| - Protocol Buffer encoding will not change going forward. | |||
| - Removing amino overhead from keys will help with the KSM. | |||
| - Have a large ecosystem of supported languages. | |||
| ### Negative | |||
| - Hardfork is required to integrate this into running chains. | |||
| ### Neutral | |||
| ## References | |||
| > Are there any relevant PR comments, issues that led up to this, or articles referenced for why we made the given design choice? If so link them here! | |||
| - {reference link} | |||