diff --git a/rpc/client/httpclient.go b/rpc/client/httpclient.go index e21c2b0fd..b4faafdcb 100644 --- a/rpc/client/httpclient.go +++ b/rpc/client/httpclient.go @@ -70,13 +70,13 @@ func (c *HTTP) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (c *HTTP) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return c.ABCIQueryWithOptions(path, data, DefaultABCIQueryOptions()) + return c.ABCIQueryWithOptions(path, data, DefaultABCIQueryOptions) } func (c *HTTP) ABCIQueryWithOptions(path string, data data.Bytes, opts ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { result := new(ctypes.ResultABCIQuery) _, err := c.rpc.Call("abci_query", - map[string]interface{}{"path": path, "data": data, "height": opts.Height, "prove": opts.Prove}, + map[string]interface{}{"path": path, "data": data, "height": opts.Height, "trusted": opts.Trusted}, result) if err != nil { return nil, errors.Wrap(err, "ABCIQuery") diff --git a/rpc/client/localclient.go b/rpc/client/localclient.go index 581ae7d16..9a14c8684 100644 --- a/rpc/client/localclient.go +++ b/rpc/client/localclient.go @@ -58,11 +58,11 @@ func (c Local) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (c Local) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return c.ABCIQueryWithOptions(path, data, DefaultABCIQueryOptions()) + return c.ABCIQueryWithOptions(path, data, DefaultABCIQueryOptions) } func (c Local) ABCIQueryWithOptions(path string, data data.Bytes, opts ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { - return core.ABCIQuery(path, data, opts.Height, opts.Prove) + return core.ABCIQuery(path, data, opts.Height, opts.Trusted) } func (c Local) BroadcastTxCommit(tx types.Tx) (*ctypes.ResultBroadcastTxCommit, error) { diff --git a/rpc/client/mock/abci.go b/rpc/client/mock/abci.go index e08490418..a05ce0b8d 100644 --- a/rpc/client/mock/abci.go +++ b/rpc/client/mock/abci.go @@ -25,11 +25,11 @@ func (a ABCIApp) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (a ABCIApp) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return a.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions()) + return a.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions) } func (a ABCIApp) ABCIQueryWithOptions(path string, data data.Bytes, opts client.ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { - q := a.App.Query(abci.RequestQuery{data, path, opts.Height, opts.Prove}) + q := a.App.Query(abci.RequestQuery{data, path, opts.Height, opts.Trusted}) return &ctypes.ResultABCIQuery{q.Result()}, nil } @@ -84,11 +84,11 @@ func (m ABCIMock) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (m ABCIMock) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return m.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions()) + return m.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions) } func (m ABCIMock) ABCIQueryWithOptions(path string, data data.Bytes, opts client.ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { - res, err := m.Query.GetResponse(QueryArgs{path, data, opts.Height, opts.Prove}) + res, err := m.Query.GetResponse(QueryArgs{path, data, opts.Height, opts.Trusted}) if err != nil { return nil, err } @@ -139,10 +139,10 @@ func (r *ABCIRecorder) _assertABCIClient() client.ABCIClient { } type QueryArgs struct { - Path string - Data data.Bytes - Height uint64 - Prove bool + Path string + Data data.Bytes + Height uint64 + Trusted bool } func (r *ABCIRecorder) addCall(call Call) { @@ -160,14 +160,14 @@ func (r *ABCIRecorder) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (r *ABCIRecorder) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return r.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions()) + return r.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions) } func (r *ABCIRecorder) ABCIQueryWithOptions(path string, data data.Bytes, opts client.ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { res, err := r.Client.ABCIQueryWithOptions(path, data, opts) r.addCall(Call{ Name: "abci_query", - Args: QueryArgs{path, data, opts.Height, opts.Prove}, + Args: QueryArgs{path, data, opts.Height, opts.Trusted}, Response: res, Error: err, }) diff --git a/rpc/client/mock/abci_test.go b/rpc/client/mock/abci_test.go index 6fe94c408..a7afa0894 100644 --- a/rpc/client/mock/abci_test.go +++ b/rpc/client/mock/abci_test.go @@ -51,7 +51,7 @@ func TestABCIMock(t *testing.T) { assert.Equal("foobar", err.Error()) // query always returns the response - query, err := m.ABCIQueryWithOptions("/", nil, client.ABCIQueryOptions{Prove: false}) + query, err := m.ABCIQueryWithOptions("/", nil, client.ABCIQueryOptions{Trusted: true}) require.Nil(err) require.NotNil(query) assert.EqualValues(key, query.Key) @@ -93,7 +93,7 @@ func TestABCIRecorder(t *testing.T) { require.Equal(0, len(r.Calls)) r.ABCIInfo() - r.ABCIQueryWithOptions("path", data.Bytes("data"), client.ABCIQueryOptions{Prove: true}) + r.ABCIQueryWithOptions("path", data.Bytes("data"), client.ABCIQueryOptions{Trusted: false}) require.Equal(2, len(r.Calls)) info := r.Calls[0] @@ -116,7 +116,7 @@ func TestABCIRecorder(t *testing.T) { require.True(ok) assert.Equal("path", qa.Path) assert.EqualValues("data", qa.Data) - assert.True(qa.Prove) + assert.False(qa.Trusted) // now add some broadcasts txs := []types.Tx{{1}, {2}, {3}} @@ -165,7 +165,7 @@ func TestABCIApp(t *testing.T) { assert.True(res.DeliverTx.Code.IsOK()) // check the key - qres, err := m.ABCIQueryWithOptions("/key", data.Bytes(key), client.ABCIQueryOptions{Prove: false}) + qres, err := m.ABCIQueryWithOptions("/key", data.Bytes(key), client.ABCIQueryOptions{Trusted: true}) require.Nil(err) assert.EqualValues(value, qres.Value) } diff --git a/rpc/client/mock/client.go b/rpc/client/mock/client.go index 2cd16a7a5..08d19cea5 100644 --- a/rpc/client/mock/client.go +++ b/rpc/client/mock/client.go @@ -85,11 +85,11 @@ func (c Client) ABCIInfo() (*ctypes.ResultABCIInfo, error) { } func (c Client) ABCIQuery(path string, data data.Bytes) (*ctypes.ResultABCIQuery, error) { - return c.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions()) + return c.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions) } func (c Client) ABCIQueryWithOptions(path string, data data.Bytes, opts client.ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) { - return core.ABCIQuery(path, data, opts.Height, opts.Prove) + return core.ABCIQuery(path, data, opts.Height, opts.Trusted) } func (c Client) BroadcastTxCommit(tx types.Tx) (*ctypes.ResultBroadcastTxCommit, error) { diff --git a/rpc/client/rpc_test.go b/rpc/client/rpc_test.go index 74a6336ee..792f0f271 100644 --- a/rpc/client/rpc_test.go +++ b/rpc/client/rpc_test.go @@ -141,7 +141,7 @@ func TestAppCalls(t *testing.T) { // wait before querying client.WaitForHeight(c, apph, nil) - qres, err := c.ABCIQueryWithOptions("/key", k, client.ABCIQueryOptions{Prove: false}) + qres, err := c.ABCIQueryWithOptions("/key", k, client.ABCIQueryOptions{Trusted: true}) if assert.Nil(err) && assert.True(qres.Code.IsOK()) { // assert.Equal(k, data.GetKey()) // only returned for proofs assert.EqualValues(v, qres.Value) @@ -189,7 +189,7 @@ func TestAppCalls(t *testing.T) { assert.Equal(block.Block.LastCommit, commit2.Commit) // and we got a proof that works! - pres, err := c.ABCIQueryWithOptions("/key", k, client.ABCIQueryOptions{Prove: true}) + pres, err := c.ABCIQueryWithOptions("/key", k, client.ABCIQueryOptions{Trusted: false}) if assert.Nil(err) && assert.True(pres.Code.IsOK()) { proof, err := iavl.ReadProof(pres.Proof) if assert.Nil(err) { diff --git a/rpc/client/types.go b/rpc/client/types.go index 1e6431c5d..134022612 100644 --- a/rpc/client/types.go +++ b/rpc/client/types.go @@ -3,11 +3,9 @@ package client // ABCIQueryOptions can be used to provide options for ABCIQuery call other // than the DefaultABCIQueryOptions. type ABCIQueryOptions struct { - Height uint64 - Prove bool + Height uint64 + Trusted bool } // DefaultABCIQueryOptions are latest height (0) and prove equal to true. -func DefaultABCIQueryOptions() ABCIQueryOptions { - return ABCIQueryOptions{Height: 0, Prove: true} -} +var DefaultABCIQueryOptions = ABCIQueryOptions{Height: 0, Trusted: false} diff --git a/rpc/core/abci.go b/rpc/core/abci.go index d65a3efe6..564c0bc63 100644 --- a/rpc/core/abci.go +++ b/rpc/core/abci.go @@ -41,18 +41,18 @@ import ( // // ### Query Parameters // -// | Parameter | Type | Default | Required | Description | -// |-----------+--------+---------+----------+---------------------------------------| -// | path | string | false | false | Path to the data ("/a/b/c") | -// | data | []byte | false | true | Data | -// | height | uint64 | 0 | false | Height (0 means latest) | -// | prove | bool | false | false | Include a proof of the data inclusion | -func ABCIQuery(path string, data data.Bytes, height uint64, prove bool) (*ctypes.ResultABCIQuery, error) { +// | Parameter | Type | Default | Required | Description | +// |-----------+--------+---------+----------+------------------------------------------------| +// | path | string | false | false | Path to the data ("/a/b/c") | +// | data | []byte | false | true | Data | +// | height | uint64 | 0 | false | Height (0 means latest) | +// | trusted | bool | false | false | Does not include a proof of the data inclusion | +func ABCIQuery(path string, data data.Bytes, height uint64, trusted bool) (*ctypes.ResultABCIQuery, error) { resQuery, err := proxyAppQuery.QuerySync(abci.RequestQuery{ Path: path, Data: data, Height: height, - Prove: prove, + Prove: !trusted, }) if err != nil { return nil, err