Browse Source

improve "curRate too low" message

Refs #1177

Note on labels:
KB - 1024
kB - 1000
https://ux.stackexchange.com/questions/13815/files-size-units-kib-vs-kb-vs-kb
pull/1194/head
Anton Kaliaev 7 years ago
parent
commit
d1fa44e816
No known key found for this signature in database GPG Key ID: 7B6881D965918214
1 changed files with 10 additions and 3 deletions
  1. +10
    -3
      blockchain/pool.go

+ 10
- 3
blockchain/pool.go View File

@ -1,6 +1,7 @@
package blockchain package blockchain
import ( import (
"fmt"
"math" "math"
"sync" "sync"
"time" "time"
@ -30,7 +31,11 @@ const (
maxTotalRequesters = 1000 maxTotalRequesters = 1000
maxPendingRequests = maxTotalRequesters maxPendingRequests = maxTotalRequesters
maxPendingRequestsPerPeer = 50 maxPendingRequestsPerPeer = 50
minRecvRate = 10240 // 10Kb/s
// Minimum recv rate to ensure we're receiving blocks from a peer fast
// enough. If a peer is not sending us data at at least that rate, we
// consider them to have timedout and we disconnect.
minRecvRate = 10240 // 10 KB/s
) )
var peerTimeoutSeconds = time.Duration(15) // not const so we can override with tests var peerTimeoutSeconds = time.Duration(15) // not const so we can override with tests
@ -88,7 +93,6 @@ func (pool *BlockPool) OnStop() {}
// Run spawns requesters as needed. // Run spawns requesters as needed.
func (pool *BlockPool) makeRequestersRoutine() { func (pool *BlockPool) makeRequestersRoutine() {
for { for {
if !pool.IsRunning() { if !pool.IsRunning() {
break break
@ -122,7 +126,10 @@ func (pool *BlockPool) removeTimedoutPeers() {
// XXX remove curRate != 0 // XXX remove curRate != 0
if curRate != 0 && curRate < minRecvRate { if curRate != 0 && curRate < minRecvRate {
pool.sendTimeout(peer.id) pool.sendTimeout(peer.id)
pool.Logger.Error("SendTimeout", "peer", peer.id, "reason", "curRate too low")
pool.Logger.Error("SendTimeout", "peer", peer.id,
"reason", "peer is not sending us data fast enough",
"curRate", fmt.Sprintf("%d KB/s", curRate/1024),
"minRate", fmt.Sprintf("%d KB/s", minRecvRate/1024))
peer.didTimeout = true peer.didTimeout = true
} }
} }


Loading…
Cancel
Save