Merge pull request #876 from tendermint/p2p-extract-key-lex-check-to-variable-for-clarity

p2p: use bytes.Equal for key comparison

p2p/secret_connection.go

@@ -67,8 +67,12 @@ func MakeSecretConnection(conn io.ReadWriteCloser, locPrivKey crypto.PrivKeyEd25
 	// Sort by lexical order.
 	loEphPub, hiEphPub := sort32(locEphPub, remEphPub)
 
+	// Check if the local ephemeral public key
+	// was the least, lexicographically sorted.
+	locIsLeast := bytes.Equal(locEphPub[:], loEphPub[:])
+
 	// Generate nonces to use for secretbox.
-	recvNonce, sendNonce := genNonces(loEphPub, hiEphPub, locEphPub == loEphPub)
+	recvNonce, sendNonce := genNonces(loEphPub, hiEphPub, locIsLeast)
 
 	// Generate common challenge to sign.
 	challenge := genChallenge(loEphPub, hiEphPub)