From c4caad772043178cfa1f34fea4a921ef0fdb70a6 Mon Sep 17 00:00:00 2001 From: Zach Ramsay Date: Thu, 9 Nov 2017 13:59:35 -0500 Subject: [PATCH] lint madness --- Makefile | 6 +++--- consensus/common.go | 18 ------------------ 2 files changed, 3 insertions(+), 21 deletions(-) delete mode 100644 consensus/common.go diff --git a/Makefile b/Makefile index 770ca2533..e1cf4842d 100644 --- a/Makefile +++ b/Makefile @@ -89,11 +89,8 @@ metalinter_test: ensure_tools @gometalinter --vendor --deadline=600s --disable-all \ --enable=deadcode \ --enable=gas \ - --enable=gosimple \ --enable=misspell \ --enable=safesql \ - --enable=structcheck \ - --enable=varcheck \ ./... #--enable=maligned \ @@ -103,14 +100,17 @@ metalinter_test: ensure_tools #--enable=gocyclo \ #--enable=goimports \ #--enable=golint \ <== comments on anything exported + #--enable=gosimple \ #--enable=gotype \ #--enable=ineffassign \ #--enable=interfacer \ #--enable=megacheck \ #--enable=staticcheck \ + #--enable=structcheck \ #--enable=unconvert \ #--enable=unparam \ #--enable=unused \ + #--enable=varcheck \ #--enable=vet \ #--enable=vetshadow \ diff --git a/consensus/common.go b/consensus/common.go deleted file mode 100644 index 836b68f5a..000000000 --- a/consensus/common.go +++ /dev/null @@ -1,18 +0,0 @@ -package consensus - -import ( - "github.com/tendermint/tendermint/types" -) - -// XXX: WARNING: this function can halt the consensus as firing events is synchronous. -// Make sure to read off the channels, and in the case of subscribeToEventRespond, to write back on it - -// NOTE: if chanCap=0, this blocks on the event being consumed -func subscribeToEvent(evsw types.EventSwitch, receiver, eventID string, chanCap int) chan interface{} { - // listen for event - ch := make(chan interface{}, chanCap) - types.AddListenerForEvent(evsw, receiver, eventID, func(data types.TMEventData) { - ch <- data - }) - return ch -}