From bf989eb2724a9e3acaaea0f6e1f02544ff082d41 Mon Sep 17 00:00:00 2001 From: Marko Date: Thu, 19 Sep 2019 15:31:28 +0200 Subject: [PATCH] fix linting (#4000) --- .golangci.yml | 1 + blockchain/v2/reactor.go | 6 ++---- blockchain/v2/routine.go | 1 + blockchain/v2/routine_test.go | 3 +-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 8b7fbd7ec..0991cdf1e 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -45,3 +45,4 @@ linters: # disabled-checks: # - wrapperFunc # - commentFormatting # https://github.com/go-critic/go-critic/issues/755 + diff --git a/blockchain/v2/reactor.go b/blockchain/v2/reactor.go index f96b325b0..25ec41224 100644 --- a/blockchain/v2/reactor.go +++ b/blockchain/v2/reactor.go @@ -13,16 +13,14 @@ type timeCheck struct { } func schedulerHandle(event Event) (Event, error) { - switch event.(type) { - case timeCheck: + if _, ok := event.(timeCheck); ok { fmt.Println("scheduler handle timeCheck") } return noOp, nil } func processorHandle(event Event) (Event, error) { - switch event.(type) { - case timeCheck: + if _, ok := event.(timeCheck); ok { fmt.Println("processor handle timeCheck") } return noOp, nil diff --git a/blockchain/v2/routine.go b/blockchain/v2/routine.go index cc7e7ea0f..a24a16f09 100644 --- a/blockchain/v2/routine.go +++ b/blockchain/v2/routine.go @@ -42,6 +42,7 @@ func newRoutine(name string, handleFunc handleFunc, bufferSize int) *Routine { } } +// nolint: unused func (rt *Routine) setLogger(logger log.Logger) { rt.logger = logger } diff --git a/blockchain/v2/routine_test.go b/blockchain/v2/routine_test.go index 2bd5a1a30..66a8cc704 100644 --- a/blockchain/v2/routine_test.go +++ b/blockchain/v2/routine_test.go @@ -15,8 +15,7 @@ type eventA struct { var done = fmt.Errorf("done") func simpleHandler(event Event) (Event, error) { - switch event.(type) { - case eventA: + if _, ok := event.(eventA); ok { return noOp, done } return noOp, nil