From b25faa761f740ed915f52beb104931197e357df3 Mon Sep 17 00:00:00 2001 From: Tess Rinearson Date: Mon, 27 Apr 2020 12:30:04 +0200 Subject: [PATCH] .github: move checklist from PR description into an auto-comment (#4745) The checklist and message in the default PR description were sometimes getting included in commit messages. This change moves that text from the PR description to a comment from a [Probot tool](https://probot.github.io/apps/auto-comment/). --- .github/PULL_REQUEST_TEMPLATE.md | 15 ++------------- .github/auto-comment.yml | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 13 deletions(-) create mode 100644 .github/auto-comment.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4af8eec23..975ad1cf5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,18 +1,7 @@ ## Description - +_Please add a description of the changes that this PR introduces and the files that +are the most critical to review._ Closes: #XXX ---- - -For contributor use: - -- [ ] Wrote tests -- [ ] Updated CHANGELOG_PENDING.md -- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. -- [ ] Updated relevant documentation (`docs/`) and code comments -- [ ] Re-reviewed `Files changed` in the Github PR explorer -- [ ] Applied Appropriate Labels diff --git a/.github/auto-comment.yml b/.github/auto-comment.yml new file mode 100644 index 000000000..7d2d07acd --- /dev/null +++ b/.github/auto-comment.yml @@ -0,0 +1,15 @@ +pullRequestOpened: > + :wave: Thanks for creating a PR! + + Before we can merge this PR, please make sure that all the following items have been + checked off. If any of the checklist items are not applicable, please leave them but + write a little note why. + + - [ ] Wrote tests + - [ ] Updated CHANGELOG_PENDING.md + - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. + - [ ] Updated relevant documentation (`docs/`) and code comments + - [ ] Re-reviewed `Files changed` in the Github PR explorer + - [ ] Applied Appropriate Labels + + Thank you for your contribution to Tendermint! :rocket: \ No newline at end of file