Browse Source

consensus: skip channel close during shutdown (#8155)

I see this panic in tests occasionally, and I don't think there's any
need to close this channel:

- it's only sent to in one place which has a select case with a
  default clause, so there's no chance of deadlocks.

- the only place we recieve from it thas a timeout.
pull/8163/head
Sam Kleinman 3 years ago
committed by GitHub
parent
commit
9a833a8495
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
  1. +0
    -2
      internal/consensus/state.go

+ 0
- 2
internal/consensus/state.go View File

@ -511,8 +511,6 @@ func (cs *State) OnStop() {
} }
} }
close(cs.onStopCh)
if cs.timeoutTicker.IsRunning() { if cs.timeoutTicker.IsRunning() {
cs.timeoutTicker.Stop() cs.timeoutTicker.Stop()
} }


Loading…
Cancel
Save