From 89462c52d9fa9d9a52ee6d7995a777a1bcc1f51d Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Tue, 18 Sep 2018 13:28:32 +0400 Subject: [PATCH] spec: add missing field to NodeInfoOther (#2426) and fix formatting Refs https://github.com/tendermint/tendermint/pull/2417#discussion_r218080500 --- docs/spec/p2p/peer.md | 1 + p2p/node_info.go | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/spec/p2p/peer.md b/docs/spec/p2p/peer.md index eb344c291..8f8f12b13 100644 --- a/docs/spec/p2p/peer.md +++ b/docs/spec/p2p/peer.md @@ -92,6 +92,7 @@ type NodeInfoOther struct { ConsensusVersion string RPCVersion string TxIndex string + RPCAddress string } ``` diff --git a/p2p/node_info.go b/p2p/node_info.go index c0718deee..a0df3d374 100644 --- a/p2p/node_info.go +++ b/p2p/node_info.go @@ -83,7 +83,8 @@ func (info NodeInfo) Validate() error { // Sanitize versions // XXX: Should we be more strict about version and address formats? other := info.Other - versions := []string{other.AminoVersion, + versions := []string{ + other.AminoVersion, other.AminoVersion, other.P2PVersion, other.ConsensusVersion,