From 76c82fd433d147545b95743774635482823bbc10 Mon Sep 17 00:00:00 2001
From: Ethan Buchman <ethan@coinculture.info>
Date: Wed, 6 Jun 2018 20:49:00 -0700
Subject: [PATCH] add more tests

---
 types/protobuf_test.go | 69 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 types/protobuf_test.go

diff --git a/types/protobuf_test.go b/types/protobuf_test.go
new file mode 100644
index 000000000..9f3b31873
--- /dev/null
+++ b/types/protobuf_test.go
@@ -0,0 +1,69 @@
+package types
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	abci "github.com/tendermint/abci/types"
+	crypto "github.com/tendermint/go-crypto"
+)
+
+func TestABCIPubKey(t *testing.T) {
+	pkEd := crypto.GenPrivKeyEd25519().PubKey()
+	pkSecp := crypto.GenPrivKeySecp256k1().PubKey()
+	testABCIPubKey(t, pkEd, ABCIPubKeyTypeEd25519)
+	testABCIPubKey(t, pkSecp, ABCIPubKeyTypeSecp256k1)
+}
+
+func testABCIPubKey(t *testing.T, pk crypto.PubKey, typeStr string) {
+	abciPubKey := TM2PB.PubKey(pk)
+	pk2, err := PB2TM.PubKey(abciPubKey)
+	assert.Nil(t, err)
+	assert.Equal(t, pk, pk2)
+}
+
+func TestABCIValidators(t *testing.T) {
+	pkEd := crypto.GenPrivKeyEd25519().PubKey()
+
+	// correct validator
+	tmValExpected := &Validator{
+		Address:     pkEd.Address(),
+		PubKey:      pkEd,
+		VotingPower: 10,
+	}
+
+	tmVal := &Validator{
+		Address:     pkEd.Address(),
+		PubKey:      pkEd,
+		VotingPower: 10,
+	}
+
+	abciVal := TM2PB.Validator(tmVal)
+	tmVals, err := PB2TM.Validators([]abci.Validator{abciVal})
+	assert.Nil(t, err)
+	assert.Equal(t, tmValExpected, tmVals[0])
+
+	// val with address
+	tmVal.Address = pkEd.Address()
+
+	abciVal = TM2PB.Validator(tmVal)
+	tmVals, err = PB2TM.Validators([]abci.Validator{abciVal})
+	assert.Nil(t, err)
+	assert.Equal(t, tmValExpected, tmVals[0])
+
+	// val with incorrect address
+	abciVal = TM2PB.Validator(tmVal)
+	abciVal.Address = []byte("incorrect!")
+	tmVals, err = PB2TM.Validators([]abci.Validator{abciVal})
+	assert.NotNil(t, err)
+	assert.Nil(t, tmVals)
+}
+
+func TestABCIConsensusParams(t *testing.T) {
+	cp := DefaultConsensusParams()
+	cp.EvidenceParams.MaxAge = 0 // TODO add this to ABCI
+	abciCP := TM2PB.ConsensusParams(cp)
+	cp2 := PB2TM.ConsensusParams(abciCP)
+
+	assert.Equal(t, *cp, cp2)
+}