From 7169d26ddf9a4d29908c0ad5c21bf6430b5a4bf9 Mon Sep 17 00:00:00 2001
From: Sam Kleinman <garen@tychoish.com>
Date: Tue, 31 Aug 2021 17:56:06 -0400
Subject: [PATCH] e2e: more reliable method for selecting node to inject
 evidence (#6880)

In retrospect my previous implementation of this node, could get
unlucky and never find the correct node. This method is more reliable.
---
 test/e2e/runner/evidence.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/test/e2e/runner/evidence.go b/test/e2e/runner/evidence.go
index 30e8d9f0a..35646ccdb 100644
--- a/test/e2e/runner/evidence.go
+++ b/test/e2e/runner/evidence.go
@@ -32,8 +32,9 @@ func InjectEvidence(testnet *e2e.Testnet, amount int) error {
 	// select a random node
 	var targetNode *e2e.Node
 
-	for i := 0; i < len(testnet.Nodes)-1; i++ {
-		targetNode = testnet.Nodes[rand.Intn(len(testnet.Nodes))] // nolint: gosec
+	for _, idx := range rand.Perm(len(testnet.Nodes)) {
+		targetNode = testnet.Nodes[idx]
+
 		if targetNode.Mode == e2e.ModeSeed {
 			targetNode = nil
 			continue