Browse Source

blockchain: comment out logger in test code that causes a race condition (#3500)

pull/3504/head
Ismail Khoffi 6 years ago
committed by Alexander Simmerl
parent
commit
6c1a4b5137
1 changed files with 3 additions and 1 deletions
  1. +3
    -1
      blockchain/pool_test.go

+ 3
- 1
blockchain/pool_test.go View File

@ -42,7 +42,9 @@ func (p testPeer) runInputRoutine() {
func (p testPeer) simulateInput(input inputData) {
block := &types.Block{Header: types.Header{Height: input.request.Height}}
input.pool.AddBlock(input.request.PeerID, block, 123)
input.t.Logf("Added block from peer %v (height: %v)", input.request.PeerID, input.request.Height)
// TODO: uncommenting this creates a race which is detected by: https://github.com/golang/go/blob/2bd767b1022dd3254bcec469f0ee164024726486/src/testing/testing.go#L854-L856
// see: https://github.com/tendermint/tendermint/issues/3390#issue-418379890
// input.t.Logf("Added block from peer %v (height: %v)", input.request.PeerID, input.request.Height)
}
type testPeers map[p2p.ID]testPeer


Loading…
Cancel
Save