From 6c0d4070c246641d226a27f06a57f6c9786565c6 Mon Sep 17 00:00:00 2001 From: Marko Date: Thu, 26 Nov 2020 16:12:25 +0100 Subject: [PATCH] ci: build for 32 bit, libs: fix overflow (#5700) --- .github/workflows/coverage.yml | 25 ++++++++++++++++++++++++- .github/workflows/tests.yml | 6 +++--- .goreleaser.yml | 3 ++- libs/math/fraction.go | 2 +- 4 files changed, 30 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index dbadb4d85..ce8d47c50 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -33,6 +33,29 @@ jobs: name: "${{ github.sha }}-03" path: ./pkgs.txt.part.03 + build-linux: + name: Build + runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + goarch: ["arm", "amd64"] + timeout-minutes: 5 + steps: + - uses: actions/setup-go@v2 + with: + go-version: "^1.15.4" + - uses: actions/checkout@v2 + - uses: technote-space/get-diff-action@v4 + with: + PATTERNS: | + **/**.go + go.mod + go.sum + - name: install + run: GOOS=linux GOARCH=${{ matrix.goarch }} make build + if: "env.GIT_DIFF != ''" + tests: runs-on: ubuntu-latest needs: split-test-files @@ -43,7 +66,7 @@ jobs: steps: - uses: actions/setup-go@v2 with: - go-version: '^1.15.4' + go-version: "^1.15.4" - uses: actions/checkout@v2 - uses: technote-space/get-diff-action@v4 with: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5a2eda03b..0e8788b96 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -52,7 +52,7 @@ jobs: test_abci_apps: runs-on: ubuntu-latest - needs: Build + needs: build timeout-minutes: 5 steps: - uses: actions/setup-go@v2 @@ -84,7 +84,7 @@ jobs: test_abci_cli: runs-on: ubuntu-latest - needs: Build + needs: build timeout-minutes: 5 steps: - uses: actions/setup-go@v2 @@ -115,7 +115,7 @@ jobs: test_apps: runs-on: ubuntu-latest - needs: Build + needs: build timeout-minutes: 5 steps: - uses: actions/setup-go@v2 diff --git a/.goreleaser.yml b/.goreleaser.yml index 494f7c245..d1c61e4e3 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -8,7 +8,7 @@ builds: - id: "Tendermint" main: ./cmd/tendermint/main.go ldflags: - - -s -w -X github.com/tendermint/tendermint/version.TMCoreSemVer={{ .Version }} + - -s -w -X github.com/tendermint/tendermint/version.TMCoreSemVer={{ .Version }} env: - CGO_ENABLED=0 goos: @@ -17,6 +17,7 @@ builds: - windows goarch: - amd64 + - arm - arm64 checksum: diff --git a/libs/math/fraction.go b/libs/math/fraction.go index e38636485..a8d285592 100644 --- a/libs/math/fraction.go +++ b/libs/math/fraction.go @@ -42,7 +42,7 @@ func ParseFraction(f string) (Fraction, error) { return Fraction{}, errors.New("denominator can't be 0") } if numerator > math.MaxInt64 || denominator > math.MaxInt64 { - return Fraction{}, fmt.Errorf("value overflow, numerator and denominator must be less than %d", math.MaxInt64) + return Fraction{}, fmt.Errorf("value overflow, numerator and denominator must be less than %d", int64(math.MaxInt64)) } return Fraction{Numerator: numerator, Denominator: denominator}, nil }