From 5c1399d803fc92f5f78f9349a4a58293524b5e5c Mon Sep 17 00:00:00 2001 From: "M. J. Fromberger" Date: Wed, 12 Jan 2022 12:17:53 -0800 Subject: [PATCH] rpc: fix mock test cases (#7571) In two cases, we check for the content of an error right after asserting that no error occurs. Fix the sense of those checks. In one case, we check that there is no error with the diagnostic "expected error". It's not clear whether this means "an error was expected" (which is what I believe) or "we got the expected error". However, given the way the mock plumbing is set up, the first interpretation seems right. --- rpc/client/mock/abci_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rpc/client/mock/abci_test.go b/rpc/client/mock/abci_test.go index 0e410d74e..18fbbf6a9 100644 --- a/rpc/client/mock/abci_test.go +++ b/rpc/client/mock/abci_test.go @@ -48,7 +48,7 @@ func TestABCIMock(t *testing.T) { // now, let's try to make some calls _, err := m.ABCIInfo(ctx) - require.NoError(t, err) + require.Error(t, err) assert.Equal(t, "foobar", err.Error()) // query always returns the response @@ -62,7 +62,7 @@ func TestABCIMock(t *testing.T) { // non-commit calls always return errors _, err = m.BroadcastTxSync(ctx, goodTx) - require.NoError(t, err) + require.Error(t, err) assert.Equal(t, "must commit", err.Error()) _, err = m.BroadcastTxAsync(ctx, goodTx) require.Error(t, err) @@ -70,7 +70,7 @@ func TestABCIMock(t *testing.T) { // commit depends on the input _, err = m.BroadcastTxCommit(ctx, badTx) - require.NoError(t, err) + require.Error(t, err) assert.Equal(t, "bad tx", err.Error()) bres, err := m.BroadcastTxCommit(ctx, goodTx) require.NoError(t, err, "%+v", err) @@ -106,7 +106,7 @@ func TestABCIRecorder(t *testing.T) { bytes.HexBytes("data"), client.ABCIQueryOptions{Prove: false}, ) - assert.NoError(t, err, "expected error on query") + assert.Error(t, err, "expected error on query") require.Equal(t, 2, len(r.Calls)) info := r.Calls[0]