Browse Source

e2e: skip broadcastTxCommit check (#6949)

I think the `Sync` check covers our primary use case, and perhaps we
can turn this back on in the future after some kind of event-system
rewrite, or RPC rewrite that will avoid the serverside timeout.
pull/6951/head
Sam Kleinman 3 years ago
committed by GitHub
parent
commit
55f6d20977
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
  1. +14
    -4
      test/e2e/tests/app_test.go

+ 14
- 4
test/e2e/tests/app_test.go View File

@ -68,7 +68,7 @@ func TestApp_Tx(t *testing.T) {
}{ }{
{ {
Name: "Sync", Name: "Sync",
WaitTime: 30 * time.Second,
WaitTime: time.Minute,
BroadcastTx: func(client *http.HTTP) broadcastFunc { BroadcastTx: func(client *http.HTTP) broadcastFunc {
return func(ctx context.Context, tx types.Tx) error { return func(ctx context.Context, tx types.Tx) error {
_, err := client.BroadcastTxSync(ctx, tx) _, err := client.BroadcastTxSync(ctx, tx)
@ -78,7 +78,13 @@ func TestApp_Tx(t *testing.T) {
}, },
{ {
Name: "Commit", Name: "Commit",
WaitTime: time.Minute,
WaitTime: 15 * time.Second,
// TODO: turn this check back on if it can
// return reliably. Currently these calls have
// a hard timeout of 10s (server side
// configured). The Sync check is probably
// safe.
ShouldSkip: true,
BroadcastTx: func(client *http.HTTP) broadcastFunc { BroadcastTx: func(client *http.HTTP) broadcastFunc {
return func(ctx context.Context, tx types.Tx) error { return func(ctx context.Context, tx types.Tx) error {
_, err := client.BroadcastTxCommit(ctx, tx) _, err := client.BroadcastTxCommit(ctx, tx)
@ -87,8 +93,12 @@ func TestApp_Tx(t *testing.T) {
}, },
}, },
{ {
Name: "Async",
WaitTime: time.Minute,
Name: "Async",
WaitTime: 90 * time.Second,
// TODO: turn this check back on if there's a
// way to avoid failures in the case that the
// transaction doesn't make it into the
// mempool. (retries?)
ShouldSkip: true, ShouldSkip: true,
BroadcastTx: func(client *http.HTTP) broadcastFunc { BroadcastTx: func(client *http.HTTP) broadcastFunc {
return func(ctx context.Context, tx types.Tx) error { return func(ctx context.Context, tx types.Tx) error {


Loading…
Cancel
Save