From 533f7c45ebf3936e7da2f49113e82ad72618f334 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Thu, 9 Nov 2017 14:58:16 -0500 Subject: [PATCH] fix bash linter warnings for atomic_broadcast integration test --- test/p2p/atomic_broadcast/test.sh | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/test/p2p/atomic_broadcast/test.sh b/test/p2p/atomic_broadcast/test.sh index 00b339631..534b9a77b 100644 --- a/test/p2p/atomic_broadcast/test.sh +++ b/test/p2p/atomic_broadcast/test.sh @@ -13,39 +13,39 @@ N=$1 echo "" # run the test on each of them -for i in `seq 1 $N`; do - addr=$(test/p2p/ip.sh $i):46657 +for i in $(seq 1 "$N"); do + addr=$(test/p2p/ip.sh "$i"):46657 # current state - HASH1=`curl -s $addr/status | jq .result.latest_app_hash` - + HASH1=$(curl -s "$addr/status" | jq .result.latest_app_hash) + # - send a tx TX=aadeadbeefbeefbeef0$i echo "Broadcast Tx $TX" - curl -s $addr/broadcast_tx_commit?tx=0x$TX + curl -s "$addr/broadcast_tx_commit?tx=0x$TX" echo "" # we need to wait another block to get the new app_hash - h1=`curl -s $addr/status | jq .result.latest_block_height` + h1=$(curl -s "$addr/status" | jq .result.latest_block_height) h2=$h1 while [ "$h2" == "$h1" ]; do sleep 1 - h2=`curl -s $addr/status | jq .result.latest_block_height` + h2=$(curl -s "$addr/status" | jq .result.latest_block_height) done # check that hash was updated - HASH2=`curl -s $addr/status | jq .result.latest_app_hash` + HASH2=$(curl -s "$addr/status" | jq .result.latest_app_hash) if [[ "$HASH1" == "$HASH2" ]]; then echo "Expected state hash to update from $HASH1. Got $HASH2" exit 1 fi # check we get the same new hash on all other nodes - for j in `seq 1 $N`; do + for j in $(seq 1 "$N"); do if [[ "$i" != "$j" ]]; then - addrJ=$(test/p2p/ip.sh $j):46657 - HASH3=`curl -s $addrJ/status | jq .result.latest_app_hash` - + addrJ=$(test/p2p/ip.sh "$j"):46657 + HASH3=$(curl -s "$addrJ/status" | jq .result.latest_app_hash) + if [[ "$HASH2" != "$HASH3" ]]; then echo "App hash for node $j doesn't match. Got $HASH3, expected $HASH2" exit 1