Browse Source

set allow_duplicate_ip to false (#2992)

* config: cors options are arrays of strings, not strings

Fixes #2980

* docs: update tendermint-core/configuration.html page

* set allow_duplicate_ip to false

* in `tendermint testnet`, set allow_duplicate_ip to true

Refs #2712

* fixes after Ismail's review
pull/3045/head
Anton Kaliaev 6 years ago
committed by Ethan Buchman
parent
commit
4d8f29f79c
4 changed files with 5 additions and 2 deletions
  1. +2
    -0
      CHANGELOG_PENDING.md
  2. +1
    -0
      cmd/tendermint/commands/testnet.go
  3. +1
    -1
      config/config.go
  4. +1
    -1
      docs/tendermint-core/configuration.md

+ 2
- 0
CHANGELOG_PENDING.md View File

@ -9,6 +9,7 @@ Special thanks to external contributors on this release:
* CLI/RPC/Config
- [cli] Removed `node` `--proxy_app=dummy` option. Use `kvstore` (`persistent_kvstore`) instead.
- [cli] Renamed `node` `--proxy_app=nilapp` to `--proxy_app=noop`.
- [config] \#2992 `allow_duplicate_ip` is now set to false
* Apps
@ -17,6 +18,7 @@ Special thanks to external contributors on this release:
* Blockchain Protocol
* P2P Protocol
- multiple connections from the same IP are now disabled by default (see `allow_duplicate_ip` config option)
### FEATURES:


+ 1
- 0
cmd/tendermint/commands/testnet.go View File

@ -145,6 +145,7 @@ func testnetFiles(cmd *cobra.Command, args []string) error {
nodeDir := filepath.Join(outputDir, fmt.Sprintf("%s%d", nodeDirPrefix, i))
config.SetRoot(nodeDir)
config.P2P.AddrBookStrict = false
config.P2P.AllowDuplicateIP = true
if populatePersistentPeers {
config.P2P.PersistentPeers = persistentPeers
}


+ 1
- 1
config/config.go View File

@ -434,7 +434,7 @@ func DefaultP2PConfig() *P2PConfig {
RecvRate: 5120000, // 5 mB/s
PexReactor: true,
SeedMode: false,
AllowDuplicateIP: true, // so non-breaking yet
AllowDuplicateIP: false,
HandshakeTimeout: 20 * time.Second,
DialTimeout: 3 * time.Second,
TestDialFail: false,


+ 1
- 1
docs/tendermint-core/configuration.md View File

@ -170,7 +170,7 @@ seed_mode = false
private_peer_ids = ""
# Toggle to disable guard against peers connecting from the same ip.
allow_duplicate_ip = true
allow_duplicate_ip = false
# Peer connection configuration.
handshake_timeout = "20s"


Loading…
Cancel
Save