From 47bc15c27a2bc8f01c6d31eca01691659871cfdb Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Sat, 29 Sep 2018 03:28:42 +0400 Subject: [PATCH] disable mempool WAL by default (#2490) --- CHANGELOG_PENDING.md | 1 + config/config.go | 2 +- docs/tendermint-core/running-in-production.md | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index c1db67632..89ac9c130 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -5,6 +5,7 @@ Special thanks to external contributors on this release: BREAKING CHANGES: * CLI/RPC/Config +- [config] `mempool.wal` is disabled by default * Apps diff --git a/config/config.go b/config/config.go index 87a741311..2ccb49083 100644 --- a/config/config.go +++ b/config/config.go @@ -503,7 +503,7 @@ func DefaultMempoolConfig() *MempoolConfig { Recheck: true, RecheckEmpty: true, Broadcast: true, - WalPath: filepath.Join(defaultDataDir, "mempool.wal"), + WalPath: "", // Each signature verification takes .5ms, size reduced until we implement // ABCI Recheck Size: 5000, diff --git a/docs/tendermint-core/running-in-production.md b/docs/tendermint-core/running-in-production.md index c774cd131..fb98626ad 100644 --- a/docs/tendermint-core/running-in-production.md +++ b/docs/tendermint-core/running-in-production.md @@ -74,6 +74,10 @@ propose it. Clients must monitor their txs by subscribing over websockets, polling for them, or using `/broadcast_tx_commit`. In the worst case, txs can be resent from the mempool WAL manually. +For the above reasons, the `mempool.wal` is disabled by default. To enable, set +`mempool.wal_dir` to where you want the WAL to be located (e.g. +`data/mempool.wal`). + ## DOS Exposure and Mitigation Validators are supposed to setup [Sentry Node