Browse Source
test: protobuf vectors for reactors (#5221)
## Description Add test vectors for all reactors - [x] state-sync - [x] privval - [x] mempool - [x] p2p - [x] evidence - [ ] light? this PR is primarily oriented at testvectors for things going over the wire. should we expand the testvectors into types as well? Closes: #XXXpull/5231/head
Marko
4 years ago
committed by
GitHub
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
15 changed files with 403 additions and 138 deletions
Unified View
Diff Options
-
+12 -25blockchain/msgs_test.go
-
+15 -45consensus/msgs_test.go
-
+90 -0evidence/reactor_test.go
-
+30 -0mempool/reactor_test.go
-
+26 -0p2p/conn/connection_test.go
-
+4 -2p2p/pex/pex_reactor.go
-
+28 -0p2p/pex/pex_reactor_test.go
-
+0 -0privval/msgs.go
-
+103 -0privval/msgs_test.go
-
+1 -1privval/signer_client.go
-
+2 -2privval/signer_requestHandler.go
-
+66 -60proto/tendermint/privval/types.pb.go
-
+1 -2proto/tendermint/privval/types.proto
-
+1 -1statesync/messages.go
-
+24 -0statesync/messages_test.go
+ 12
- 25
blockchain/msgs_test.go
View File
+ 15
- 45
consensus/msgs_test.go
View File
+ 90
- 0
evidence/reactor_test.go
View File
+ 30
- 0
mempool/reactor_test.go
View File
+ 26
- 0
p2p/conn/connection_test.go
View File
+ 4
- 2
p2p/pex/pex_reactor.go
View File
+ 28
- 0
p2p/pex/pex_reactor_test.go
View File
privval/messages.go → privval/msgs.go
View File
+ 103
- 0
privval/msgs_test.go
View File
| @ -0,0 +1,103 @@ | |||||
| package privval | |||||
| import ( | |||||
| "encoding/hex" | |||||
| "testing" | |||||
| "time" | |||||
| "github.com/gogo/protobuf/proto" | |||||
| "github.com/stretchr/testify/require" | |||||
| "github.com/tendermint/tendermint/crypto" | |||||
| "github.com/tendermint/tendermint/crypto/ed25519" | |||||
| cryptoenc "github.com/tendermint/tendermint/crypto/encoding" | |||||
| "github.com/tendermint/tendermint/crypto/tmhash" | |||||
| privproto "github.com/tendermint/tendermint/proto/tendermint/privval" | |||||
| tmproto "github.com/tendermint/tendermint/proto/tendermint/types" | |||||
| "github.com/tendermint/tendermint/types" | |||||
| ) | |||||
| var stamp = time.Date(2019, 10, 13, 16, 14, 44, 0, time.UTC) | |||||
| func exampleVote() *types.Vote { | |||||
| return &types.Vote{ | |||||
| Type: tmproto.SignedMsgType(1), | |||||
| Height: 3, | |||||
| Round: 2, | |||||
| Timestamp: stamp, | |||||
| BlockID: types.BlockID{ | |||||
| Hash: tmhash.Sum([]byte("blockID_hash")), | |||||
| PartSetHeader: types.PartSetHeader{ | |||||
| Total: 1000000, | |||||
| Hash: tmhash.Sum([]byte("blockID_part_set_header_hash")), | |||||
| }, | |||||
| }, | |||||
| ValidatorAddress: crypto.AddressHash([]byte("validator_address")), | |||||
| ValidatorIndex: 56789, | |||||
| } | |||||
| } | |||||
| func exampleProposal() *types.Proposal { | |||||
| return &types.Proposal{ | |||||
| Type: tmproto.SignedMsgType(1), | |||||
| Height: 3, | |||||
| Round: 2, | |||||
| Timestamp: stamp, | |||||
| POLRound: 2, | |||||
| Signature: []byte("it's a signature"), | |||||
| BlockID: types.BlockID{ | |||||
| Hash: tmhash.Sum([]byte("blockID_hash")), | |||||
| PartSetHeader: types.PartSetHeader{ | |||||
| Total: 1000000, | |||||
| Hash: tmhash.Sum([]byte("blockID_part_set_header_hash")), | |||||
| }, | |||||
| }, | |||||
| } | |||||
| } | |||||
| // nolint:lll // ignore line length for tests | |||||
| func TestPrivvalVectors(t *testing.T) { | |||||
| pk := ed25519.GenPrivKeyFromSecret([]byte("it's a secret")).PubKey() | |||||
| ppk, err := cryptoenc.PubKeyToProto(pk) | |||||
| require.NoError(t, err) | |||||
| // Generate a simple vote | |||||
| vote := exampleVote() | |||||
| votepb := vote.ToProto() | |||||
| // Generate a simple proposal | |||||
| proposal := exampleProposal() | |||||
| proposalpb := proposal.ToProto() | |||||
| // Create a Reuseable remote error | |||||
| remoteError := &privproto.RemoteSignerError{Code: 1, Description: "it's a error"} | |||||
| testCases := []struct { | |||||
| testName string | |||||
| msg proto.Message | |||||
| expBytes string | |||||
| }{ | |||||
| {"ping request", &privproto.PingRequest{}, ""}, | |||||
| {"ping response", &privproto.PingResponse{}, ""}, | |||||
| {"pubKey request", &privproto.PubKeyRequest{}, "0a00"}, | |||||
| {"pubKey response", &privproto.PubKeyResponse{PubKey: &ppk, Error: nil}, "12240a220a20556a436f1218d30942efe798420f51dc9b6a311b929c578257457d05c5fcf230"}, | |||||
| {"pubKey response with error", &privproto.PubKeyResponse{PubKey: nil, Error: remoteError}, "121212100801120c697427732061206572726f72"}, | |||||
| {"Vote Request", &privproto.SignVoteRequest{Vote: votepb}, "1a760a74080110031802224a0a208b01023386c371778ecb6368573e539afc3cc860ec3a2f614e54fe5652f4fc80122608c0843d122072db3d959635dff1bb567bedaa70573392c5159666a3f8caf11e413aac52207a2a0608f49a8ded0532146af1f4111082efb388211bc72c55bcd61e9ac3d538d5bb03"}, | |||||
| {"Vote Response", &privproto.SignedVoteResponse{Vote: votepb, Error: nil}, "22760a74080110031802224a0a208b01023386c371778ecb6368573e539afc3cc860ec3a2f614e54fe5652f4fc80122608c0843d122072db3d959635dff1bb567bedaa70573392c5159666a3f8caf11e413aac52207a2a0608f49a8ded0532146af1f4111082efb388211bc72c55bcd61e9ac3d538d5bb03"}, | |||||
| {"Vote Response with error", &privproto.SignedVoteResponse{Vote: nil, Error: remoteError}, "221212100801120c697427732061206572726f72"}, | |||||
| {"Proposal Request", &privproto.SignProposalRequest{Proposal: proposalpb}, "2a700a6e08011003180220022a4a0a208b01023386c371778ecb6368573e539afc3cc860ec3a2f614e54fe5652f4fc80122608c0843d122072db3d959635dff1bb567bedaa70573392c5159666a3f8caf11e413aac52207a320608f49a8ded053a10697427732061207369676e6174757265"}, | |||||
| {"Proposal Response", &privproto.SignedProposalResponse{Proposal: proposalpb, Error: nil}, "32700a6e08011003180220022a4a0a208b01023386c371778ecb6368573e539afc3cc860ec3a2f614e54fe5652f4fc80122608c0843d122072db3d959635dff1bb567bedaa70573392c5159666a3f8caf11e413aac52207a320608f49a8ded053a10697427732061207369676e6174757265"}, | |||||
| {"Proposal Response with error", &privproto.SignedProposalResponse{Proposal: nil, Error: remoteError}, "321212100801120c697427732061206572726f72"}, | |||||
| } | |||||
| for _, tc := range testCases { | |||||
| tc := tc | |||||
| pm := mustWrapMsg(tc.msg) | |||||
| bz, err := pm.Marshal() | |||||
| require.NoError(t, err, tc.testName) | |||||
| require.Equal(t, tc.expBytes, hex.EncodeToString(bz), tc.testName) | |||||
| } | |||||
| } | |||||