.github/workflows: cleanup yaml for e2e nightlies (#6049)

.github/workflows/e2e-nightly-34x.yml

@@ -1,5 +1,9 @@
 # Runs randomly generated E2E testnets nightly
 # on the 0.34.x release branch
+
+# !! If you change something in this file, you probably want
+# to update the e2e-nightly-master workflow as well!
+
 name: e2e-nightly-34x
 on:
   workflow_dispatch: # allow running workflow manually, in theory
@@ -56,7 +60,7 @@ jobs:
           SLACK_FOOTER: ''
 
   e2e-nightly-success: # may turn this off once they seem to pass consistently
-    needs: e2e-nightly-test-2
+    needs: e2e-nightly-test
     if: ${{ success() }}
     runs-on: ubuntu-latest
     steps:

.github/workflows/e2e-nightly-master.yml

@@ -1,4 +1,8 @@
 # Runs randomly generated E2E testnets nightly on master
+
+# !! If you change something in this file, you probably want
+# to update the e2e-nightly-34x workflow as well!
+
 name: e2e-nightly-master
 on:
   workflow_dispatch: # allow running workflow manually
@@ -49,7 +53,7 @@ jobs:
           SLACK_USERNAME: Nightly E2E Tests
           SLACK_ICON_EMOJI: ':skull:'
           SLACK_COLOR: danger
-          SLACK_MESSAGE: Nightly E2E (copy) tests failed on master
+          SLACK_MESSAGE: Nightly E2E tests failed on master
           SLACK_FOOTER: ''
 
   e2e-nightly-success: # may turn this off once they seem to pass consistently
@@ -65,5 +69,5 @@ jobs:
           SLACK_USERNAME: Nightly E2E Tests
           SLACK_ICON_EMOJI: ':white_check_mark:'
           SLACK_COLOR: good
-          SLACK_MESSAGE: Nightly E2E (copy) tests passed on master
+          SLACK_MESSAGE: Nightly E2E tests passed on master
           SLACK_FOOTER: ''