From 60a64af28d3540da94f4542192450fb8b1ce5a47 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Thu, 8 Mar 2018 18:50:59 +0400 Subject: [PATCH 1/2] add 2 more points to ISSUE_TEMPLATE Refs #1291 --- .github/ISSUE_TEMPLATE | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/ISSUE_TEMPLATE b/.github/ISSUE_TEMPLATE index 6b0b11f0d..e714a6ffe 100644 --- a/.github/ISSUE_TEMPLATE +++ b/.github/ISSUE_TEMPLATE @@ -37,5 +37,8 @@ in a case of bug. **How to reproduce it** (as minimally and precisely as possible): +**Logs (you can paste a part showing an error or attach the whole file)**: + +**`/dump_consensus_state` output for consensus bugs** **Anything else do we need to know**: From 018da09f1405e29c8202265c9396524cab18ffc4 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Thu, 8 Mar 2018 18:55:14 +0400 Subject: [PATCH 2/2] do not run complete test suite on `make` bad dev experience --- Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 352ef6a37..5fdc6a803 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,7 @@ PACKAGES=$(shell go list ./... | grep -v '/vendor/') BUILD_TAGS?=tendermint BUILD_FLAGS = -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`git rev-parse --short=8 HEAD`" -all: check build test_integrations install +all: check build test install check: check_tools ensure_deps @@ -81,7 +81,7 @@ build_docker_test_image: test_cover: # run the go unit tests with coverage bash test/test_cover.sh - + test_apps: # run the app tests using bash # requires `abci-cli` and `tendermint` binaries installed @@ -186,4 +186,6 @@ metalinter_all: # To avoid unintended conflicts with file names, always add to .PHONY # unless there is a reason not to. # https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html -.PHONY: check build build_race dist install check_tools get_tools update_tools get_vendor_deps draw_depsbuild_test_docker_image test_cover test_apps test_persistence test_p2p test test_race test_libs test_integrations test_release test100 vagrant_test fmt +.PHONY: check build build_race dist install check_tools get_tools update_tools + get_vendor_deps draw_deps test_cover test_apps test_persistence test_p2p test + test_race test_libs test_integrations test_release test100 vagrant_test fmt