Browse Source

rpc: log update (#6825)

We INFO log every `ABCIQuery`. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary.

Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK


/cc @marbar3778
pull/6827/head
Aleksandr Bezobchuk 3 years ago
committed by GitHub
parent
commit
393a02a729
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
  1. +2
    -0
      CHANGELOG_PENDING.md
  2. +2
    -1
      rpc/core/abci.go

+ 2
- 0
CHANGELOG_PENDING.md View File

@ -108,6 +108,8 @@ Friendly reminder: We have a [bug bounty program](https://hackerone.com/tendermi
- [statesync/event] \#6700 Emit statesync status start/end event (@JayT106)
### IMPROVEMENTS
- [rpc] \#6825 Remove egregious INFO log from `ABCI#Query` RPC. (@alexanderbez)
- [libs/log] Console log formatting changes as a result of \#6534 and \#6589. (@tychoish)
- [statesync] \#6566 Allow state sync fetchers and request timeout to be configurable. (@alexanderbez)
- [types] \#6478 Add `block_id` to `newblock` event (@jeebster)


+ 2
- 1
rpc/core/abci.go View File

@ -26,7 +26,7 @@ func (env *Environment) ABCIQuery(
if err != nil {
return nil, err
}
env.Logger.Info("ABCIQuery", "path", path, "data", data, "result", resQuery)
return &ctypes.ResultABCIQuery{Response: *resQuery}, nil
}
@ -37,5 +37,6 @@ func (env *Environment) ABCIInfo(ctx *rpctypes.Context) (*ctypes.ResultABCIInfo,
if err != nil {
return nil, err
}
return &ctypes.ResultABCIInfo{Response: *resInfo}, nil
}

Loading…
Cancel
Save