diff --git a/p2p/conn/connection.go b/p2p/conn/connection.go index 65495074f..dfbd76f0a 100644 --- a/p2p/conn/connection.go +++ b/p2p/conn/connection.go @@ -624,8 +624,9 @@ FOR_LOOP: // never block } case *tmp2p.Packet_PacketMsg: - channel, ok := c.channelsIdx[byte(pkt.PacketMsg.ChannelID)] - if !ok || channel == nil { + channelID := byte(pkt.PacketMsg.ChannelID) + channel, ok := c.channelsIdx[channelID] + if pkt.PacketMsg.ChannelID < 0 || pkt.PacketMsg.ChannelID > math.MaxUint8 || !ok || channel == nil { err := fmt.Errorf("unknown channel %X", pkt.PacketMsg.ChannelID) c.Logger.Debug("Connection failed @ recvRoutine", "conn", c, "err", err) c.stopForError(err) @@ -641,9 +642,9 @@ FOR_LOOP: break FOR_LOOP } if msgBytes != nil { - c.Logger.Debug("Received bytes", "chID", pkt.PacketMsg.ChannelID, "msgBytes", fmt.Sprintf("%X", msgBytes)) + c.Logger.Debug("Received bytes", "chID", channelID, "msgBytes", msgBytes) // NOTE: This means the reactor.Receive runs in the same thread as the p2p recv routine - c.onReceive(byte(pkt.PacketMsg.ChannelID), msgBytes) + c.onReceive(channelID, msgBytes) } default: err := fmt.Errorf("unknown message type %v", reflect.TypeOf(packet)) diff --git a/p2p/conn/connection_test.go b/p2p/conn/connection_test.go index 6dadfb486..c41a46c48 100644 --- a/p2p/conn/connection_test.go +++ b/p2p/conn/connection_test.go @@ -587,3 +587,47 @@ func TestConnVectors(t *testing.T) { require.Equal(t, tc.expBytes, hex.EncodeToString(bz), tc.testName) } } + +func TestMConnectionChannelOverflow(t *testing.T) { + chOnErr := make(chan struct{}) + chOnRcv := make(chan struct{}) + + mconnClient, mconnServer := newClientAndServerConnsForReadErrors(t, chOnErr) + t.Cleanup(stopAll(t, mconnClient, mconnServer)) + + mconnServer.onReceive = func(chID byte, msgBytes []byte) { + chOnRcv <- struct{}{} + } + + client := mconnClient.conn + protoWriter := protoio.NewDelimitedWriter(client) + + var packet = tmp2p.PacketMsg{ + ChannelID: 0x01, + EOF: true, + Data: []byte(`42`), + } + _, err := protoWriter.WriteMsg(mustWrapPacket(&packet)) + require.NoError(t, err) + assert.True(t, expectSend(chOnRcv)) + + packet.ChannelID = int32(1025) + _, err = protoWriter.WriteMsg(mustWrapPacket(&packet)) + require.NoError(t, err) + assert.False(t, expectSend(chOnRcv)) + +} + +type stopper interface { + Stop() error +} + +func stopAll(t *testing.T, stoppers ...stopper) func() { + return func() { + for _, s := range stoppers { + if err := s.Stop(); err != nil { + t.Log(err) + } + } + } +}