Browse Source

remove TODO for prepare proposal

wb/txrset
William Banfield 3 years ago
parent
commit
333b25cfbe
No known key found for this signature in database GPG Key ID: EFAD3442BF29E3AC
3 changed files with 4 additions and 4 deletions
  1. +0
    -3
      abci/example/kvstore/kvstore.go
  2. +3
    -0
      abci/types/types.go
  3. +1
    -1
      internal/state/execution.go

+ 0
- 3
abci/example/kvstore/kvstore.go View File

@ -433,9 +433,6 @@ func (app *Application) execPrepareTx(tx []byte) *types.ExecTxResult {
// substPrepareTx subst all the preparetx in the blockdata // substPrepareTx subst all the preparetx in the blockdata
// to null string(could be any arbitrary string). // to null string(could be any arbitrary string).
func (app *Application) substPrepareTx(blockData [][]byte) []*types.TxRecord { func (app *Application) substPrepareTx(blockData [][]byte) []*types.TxRecord {
// TODO: this mechanism will change with the current spec of PrepareProposal
// We now have a special type for marking a tx as changed
trs := make([]*types.TxRecord, len(blockData)) trs := make([]*types.TxRecord, len(blockData))
for i, tx := range blockData { for i, tx := range blockData {
if isPrepareTx(tx) { if isPrepareTx(tx) {


+ 3
- 0
abci/types/types.go View File

@ -251,6 +251,9 @@ func (rpp *ResponsePrepareProposal) Validate(maxSizeBytes int64, otxs [][]byte)
if !rpp.ModifiedTx { if !rpp.ModifiedTx {
// This method currently only checks the validity of the TxRecords field. // This method currently only checks the validity of the TxRecords field.
// If ModifiedTx is false, then we can ignore the validity of the TxRecords field. // If ModifiedTx is false, then we can ignore the validity of the TxRecords field.
//
// TODO: When implementing VoteExensions, AppSignedUpdates may be modified by the application
// and this method should be updated to validate the AppSignedUpdates.
return nil return nil
} }


+ 1
- 1
internal/state/execution.go View File

@ -429,7 +429,7 @@ func extendedCommitInfo(c abci.CommitInfo) abci.ExtendedCommitInfo {
Validator: c.Votes[i].Validator, Validator: c.Votes[i].Validator,
SignedLastBlock: c.Votes[i].SignedLastBlock, SignedLastBlock: c.Votes[i].SignedLastBlock,
/* /*
TODO: Include extended vote information once vote extension vote is complete.
TODO: Include vote extensions information when implementing vote extension is complete.
VoteExtension: []byte{}, VoteExtension: []byte{},
*/ */
} }


Loading…
Cancel
Save