From 287110d4256006c37c9e1948169750beb830859f Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Wed, 27 May 2020 13:31:02 +0400 Subject: [PATCH] consensus: bring back log.Error statement (#4899) Refs #3406 cs.Logger is protected by a global mutex, so it cannot be a reason for the halt in #3401. --- consensus/state.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/consensus/state.go b/consensus/state.go index 7aadc56da..5524eb268 100644 --- a/consensus/state.go +++ b/consensus/state.go @@ -734,11 +734,9 @@ func (cs *State) handleMsg(mi msgInfo) { return } - if err != nil { // nolint:staticcheck - // Causes TestReactorValidatorSetChanges to timeout - // https://github.com/tendermint/tendermint/issues/3406 - // cs.Logger.Error("Error with msg", "height", cs.Height, "round", cs.Round, - // "peer", peerID, "err", err, "msg", msg) + if err != nil { + cs.Logger.Error("Error with msg", "height", cs.Height, "round", cs.Round, + "peer", peerID, "err", err, "msg", msg) } }