From 3cb7013c3886f8144e8791908c9c07e3072b357c Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Tue, 16 Apr 2019 13:33:51 +0400 Subject: [PATCH 1/3] update changelog --- CHANGELOG.md | 32 ++++++++++++++++++++++++++++---- CHANGELOG_PENDING.md | 3 +-- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 057b2e7be..161514778 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,28 @@ # Changelog +## v0.31.5 + +*April 16th, 2019* + +This release fixes a regression from v0.31.4 where, in existing chains that +were upgraded, `/validators` could return an empty validator set. This is true +for almost all heights given the validator set remains the same. + +Special thanks to external contributors on this release: +@brapse, @guagualvcha, @dongsam, @phucc + +### IMPROVEMENTS: + +- [libs/common] CMap: slight optimization in Keys() and Values() (@phucc) +- [gitignore] gitignore: add .vendor-new (@dongsam) + +### BUG FIXES: + +- [state] [\#3537](https://github.com/tendermint/tendermint/pull/3537#issuecomment-482711833) + LoadValidators: do not return an empty validator set +- [blockchain] [\#3457](https://github.com/tendermint/tendermint/issues/3457) + Fix "peer did not send us anything" in `fast_sync` mode when under high pressure + ## v0.31.4 *April 12th, 2019* @@ -9,13 +32,14 @@ the address book. This swallowed the peer's self-reported port which is importan It brings back `NetAddress()` to `NodeInfo` and uses it instead of `SocketAddr` for adding peers. Additionally, it improves response time on the `/validators` or `/status` RPC endpoints. As a side-effect it makes these RPC endpoint more difficult to DoS and fixes a performance degradation in `ExecCommitBlock`. -Also, it contains an [ADR](https://github.com/tendermint/tendermint/pull/3539) that proposes decoupling the -responsibility for peer behaviour from the `p2p.Switch` (by @brapse). +Also, it contains an [ADR](https://github.com/tendermint/tendermint/pull/3539) that proposes decoupling the +responsibility for peer behaviour from the `p2p.Switch` (by @brapse). Special thanks to external contributors on this release: @brapse, @guagualvcha, @mydring ### IMPROVEMENTS: + - [p2p] [\#3463](https://github.com/tendermint/tendermint/pull/3463) Do not log "Can't add peer's address to addrbook" error for a private peer - [p2p] [\#3547](https://github.com/tendermint/tendermint/pull/3547) Fix a couple of annoying typos (@mdyring) @@ -43,8 +67,8 @@ panic if the lookup failed. ### BREAKING CHANGES: * Go API - - [crypto/secp256k1] [\#3439](https://github.com/tendermint/tendermint/issues/3439) - The `secp256k1.GenPrivKeySecp256k1` function has changed to guarantee that it returns a valid key, which means it + - [crypto/secp256k1] [\#3439](https://github.com/tendermint/tendermint/issues/3439) + The `secp256k1.GenPrivKeySecp256k1` function has changed to guarantee that it returns a valid key, which means it will return a different private key than in previous versions for the same secret. ### BUG FIXES: diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index 36c64be5e..fae9e6568 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -1,4 +1,4 @@ -## v0.31.5 +## v0.31.6 ** @@ -19,4 +19,3 @@ ### IMPROVEMENTS: ### BUG FIXES: -- [state] [\#3537](https://github.com/tendermint/tendermint/pull/3537#issuecomment-482711833) LoadValidators: do not return an empty validator set From 4474a5ec70fad39d78b28a543d72c25715bfca84 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Tue, 16 Apr 2019 13:34:01 +0400 Subject: [PATCH 2/3] bump version --- version/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version/version.go b/version/version.go index 9ba38de6c..a7559d499 100644 --- a/version/version.go +++ b/version/version.go @@ -20,7 +20,7 @@ const ( // Must be a string because scripts like dist.sh read this file. // XXX: Don't change the name of this variable or you will break // automation :) - TMCoreSemVer = "0.31.4" + TMCoreSemVer = "0.31.5" // ABCISemVer is the semantic version of the ABCI library ABCISemVer = "0.16.0" From 18bd5b627a99927877a92b50bee705aacf913b63 Mon Sep 17 00:00:00 2001 From: Ismail Khoffi Date: Tue, 16 Apr 2019 15:13:30 +0400 Subject: [PATCH 3/3] Apply suggestions from code review Co-Authored-By: melekes --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 161514778..9d498060b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,20 +6,20 @@ This release fixes a regression from v0.31.4 where, in existing chains that were upgraded, `/validators` could return an empty validator set. This is true -for almost all heights given the validator set remains the same. +for almost all heights, given the validator set remains the same. Special thanks to external contributors on this release: @brapse, @guagualvcha, @dongsam, @phucc ### IMPROVEMENTS: -- [libs/common] CMap: slight optimization in Keys() and Values() (@phucc) +- [libs/common] `CMap`: slight optimization in `Keys()` and `Values()` (@phucc) - [gitignore] gitignore: add .vendor-new (@dongsam) ### BUG FIXES: - [state] [\#3537](https://github.com/tendermint/tendermint/pull/3537#issuecomment-482711833) - LoadValidators: do not return an empty validator set + `LoadValidators`: do not return an empty validator set - [blockchain] [\#3457](https://github.com/tendermint/tendermint/issues/3457) Fix "peer did not send us anything" in `fast_sync` mode when under high pressure