From 1e6de1ec946054ec594894ef49f4dfb9ee5c954f Mon Sep 17 00:00:00 2001 From: Callum Date: Thu, 23 Apr 2020 08:06:51 +0200 Subject: [PATCH] check it has been committed before verifying --- state/validation.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/state/validation.go b/state/validation.go index 18608ab2c..e1e577e5c 100644 --- a/state/validation.go +++ b/state/validation.go @@ -132,12 +132,14 @@ func validateBlock(evidencePool EvidencePool, stateDB dbm.DB, state State, block // Validate all evidence. for _, ev := range block.Evidence.Evidence { + if evidencePool != nil { + if evidencePool.IsCommitted(ev) { + return types.NewErrEvidenceInvalid(ev, errors.New("evidence was already committed")) + } + } if err := VerifyEvidence(stateDB, state, ev, &block.Header); err != nil { return types.NewErrEvidenceInvalid(ev, err) } - if evidencePool != nil && evidencePool.IsCommitted(ev) { - return types.NewErrEvidenceInvalid(ev, errors.New("evidence was already committed")) - } } // NOTE: We can't actually verify it's the right proposer because we dont