Browse Source

remove some TODOs

pull/592/head
Ethan Buchman 7 years ago
parent
commit
0f293bfc2b
2 changed files with 0 additions and 4 deletions
  1. +0
    -1
      state/execution.go
  2. +0
    -3
      types/evidence.go

+ 0
- 1
state/execution.go View File

@ -313,7 +313,6 @@ func (s *State) validateBlock(b *types.Block) error {
if _, err := s.VerifyEvidence(ev); err != nil {
return types.NewEvidenceInvalidErr(ev, err)
}
// TODO: mark evidence as committed
}
return nil


+ 0
- 3
types/evidence.go View File

@ -126,9 +126,6 @@ func (dve *DuplicateVoteEvidence) Hash() []byte {
// Verify returns an error if the two votes aren't conflicting.
// To be conflicting, they must be from the same validator, for the same H/R/S, but for different blocks.
func (dve *DuplicateVoteEvidence) Verify(chainID string) error {
// TODO: verify (cs.Height - dve.Height) < MaxHeightDiff
// H/R/S must be the same
if dve.VoteA.Height != dve.VoteB.Height ||
dve.VoteA.Round != dve.VoteB.Round ||


Loading…
Cancel
Save