From 0d7d16005a256e9080fd8df45e0483bfe90d18ed Mon Sep 17 00:00:00 2001 From: Ethan Buchman Date: Sat, 20 Jan 2018 21:44:09 -0500 Subject: [PATCH] fixes --- node/node.go | 14 ++++++++------ p2p/switch.go | 2 +- p2p/types.go | 12 ++++++++++++ rpc/core/pipe.go | 6 +++--- 4 files changed, 24 insertions(+), 10 deletions(-) create mode 100644 p2p/types.go diff --git a/node/node.go b/node/node.go index 3012ed057..cab8aa805 100644 --- a/node/node.go +++ b/node/node.go @@ -22,7 +22,9 @@ import ( "github.com/tendermint/tendermint/evidence" mempl "github.com/tendermint/tendermint/mempool" "github.com/tendermint/tendermint/p2p" + "github.com/tendermint/tendermint/p2p/pex" "github.com/tendermint/tendermint/p2p/trust" + p2ptypes "github.com/tendermint/tendermint/p2p/types" "github.com/tendermint/tendermint/proxy" rpccore "github.com/tendermint/tendermint/rpc/core" grpccore "github.com/tendermint/tendermint/rpc/grpc" @@ -97,7 +99,7 @@ type Node struct { // network sw *p2p.Switch // p2p connections - addrBook *p2p.AddrBook // known peers + addrBook pex.AddrBook // known peers trustMetricStore *trust.TrustMetricStore // trust metrics for all peers // services @@ -238,10 +240,10 @@ func NewNode(config *cfg.Config, sw.AddReactor("EVIDENCE", evidenceReactor) // Optionally, start the pex reactor - var addrBook *p2p.AddrBook + var addrBook pex.AddrBook var trustMetricStore *trust.TrustMetricStore if config.P2P.PexReactor { - addrBook = p2p.NewAddrBook(config.P2P.AddrBookFile(), config.P2P.AddrBookStrict) + addrBook = pex.NewAddrBook(config.P2P.AddrBookFile(), config.P2P.AddrBookStrict) addrBook.SetLogger(p2pLogger.With("book", config.P2P.AddrBookFile())) // Get the trust metric history data @@ -256,8 +258,8 @@ func NewNode(config *cfg.Config, if config.P2P.Seeds != "" { seeds = strings.Split(config.P2P.Seeds, ",") } - pexReactor := p2p.NewPEXReactor(addrBook, - &p2p.PEXReactorConfig{Seeds: seeds}) + pexReactor := pex.NewPEXReactor(addrBook, + &pex.PEXReactorConfig{Seeds: seeds}) pexReactor.SetLogger(p2pLogger) sw.AddReactor("PEX", pexReactor) } @@ -374,7 +376,7 @@ func (n *Node) OnStart() error { // Generate node PrivKey // TODO: pass in like priv_val - nodeKey, err := p2p.LoadOrGenNodeKey(n.config.NodeKeyFile()) + nodeKey, err := p2ptypes.LoadOrGenNodeKey(n.config.NodeKeyFile()) if err != nil { return err } diff --git a/p2p/switch.go b/p2p/switch.go index ec54478cf..c9938374c 100644 --- a/p2p/switch.go +++ b/p2p/switch.go @@ -35,7 +35,7 @@ const ( //----------------------------------------------------------------------------- type AddrBook interface { - AddAddress(addr *types.NetAddress, src *types.NetAddress) + AddAddress(addr *types.NetAddress, src *types.NetAddress) error } //----------------------------------------------------------------------------- diff --git a/p2p/types.go b/p2p/types.go new file mode 100644 index 000000000..db7469ec0 --- /dev/null +++ b/p2p/types.go @@ -0,0 +1,12 @@ +package p2p + +import ( + "github.com/tendermint/tendermint/p2p/tmconn" + "github.com/tendermint/tendermint/p2p/types" +) + +type ID = types.ID +type NodeInfo = types.NodeInfo + +type ChannelDescriptor = tmconn.ChannelDescriptor +type ConnectionStatus = tmconn.ConnectionStatus diff --git a/rpc/core/pipe.go b/rpc/core/pipe.go index 301977ac3..2edb3f3d1 100644 --- a/rpc/core/pipe.go +++ b/rpc/core/pipe.go @@ -32,7 +32,7 @@ type P2P interface { NumPeers() (outbound, inbound, dialig int) NodeInfo() p2p.NodeInfo IsListening() bool - DialPeersAsync(*p2p.AddrBook, []string, bool) error + DialPeersAsync(p2p.AddrBook, []string, bool) error } //---------------------------------------------- @@ -54,7 +54,7 @@ var ( // objects pubKey crypto.PubKey genDoc *types.GenesisDoc // cache the genesis structure - addrBook *p2p.AddrBook + addrBook p2p.AddrBook txIndexer txindex.TxIndexer consensusReactor *consensus.ConsensusReactor eventBus *types.EventBus // thread safe @@ -94,7 +94,7 @@ func SetGenesisDoc(doc *types.GenesisDoc) { genDoc = doc } -func SetAddrBook(book *p2p.AddrBook) { +func SetAddrBook(book p2p.AddrBook) { addrBook = book }