From 0cd82fa166ed0f91a7cc7e62f4815f714595101a Mon Sep 17 00:00:00 2001
From: Liamsi <Liamsi@users.noreply.github.com>
Date: Wed, 13 Jun 2018 01:11:21 -0700
Subject: [PATCH] add empty struct examples

---
 types/proto3_test.go | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

diff --git a/types/proto3_test.go b/types/proto3_test.go
index bffe1cf75..e06341821 100644
--- a/types/proto3_test.go
+++ b/types/proto3_test.go
@@ -9,7 +9,6 @@ import (
 )
 
 func TestProto3Compatibility(t *testing.T) {
-	// TODO(ismail): table tests instead...
 	tm, err := time.Parse("Mon Jan 2 15:04:05 -0700 MST 2006", "Mon Jan 2 15:04:05 -0700 MST 2006")
 	assert.NoError(t, err)
 	seconds := tm.Unix()
@@ -32,7 +31,6 @@ func TestProto3Compatibility(t *testing.T) {
 		ValidatorsHash:[]byte("validators hash"),
 
 	}
-	// TODO(ismail): add another test where parts are missing (to see if default values are treated equiv.)
 	aminoHeader := Header{
 		ChainID: "cosmos",
 		Height:150,
@@ -57,4 +55,37 @@ func TestProto3Compatibility(t *testing.T) {
 	assert.NoError(t, err, "unexpected error")
 	// This works:
 	assert.Equal(t, ab, pb, "encoding doesn't match")
+
+	emptyLastBlockPb := proto3.Header{
+		ChainID: "cosmos",
+		Height:150,
+		Time: &proto3.Timestamp{Seconds:seconds, Nanos:nanos},
+		NumTxs: 7,
+		LastBlockID: &proto3.BlockID{
+			PartsHeader: &proto3.PartSetHeader{},
+		},
+		TotalTxs: 100,
+		LastCommitHash: []byte("commit hash"),
+		DataHash: []byte("data hash"),
+		ValidatorsHash:[]byte("validators hash"),
+
+	}
+	emptyLastBlockAm := Header{
+		ChainID: "cosmos",
+		Height:150,
+		Time: tm,
+		NumTxs: 7,
+		TotalTxs: 100,
+		LastCommitHash: []byte("commit hash"),
+		DataHash: []byte("data hash"),
+		ValidatorsHash:[]byte("validators hash"),
+	}
+
+	ab, err = cdc.MarshalBinaryBare(emptyLastBlockAm)
+	assert.NoError(t, err, "unexpected error")
+
+	pb, err = proto.Marshal(&emptyLastBlockPb)
+	assert.NoError(t, err, "unexpected error")
+	// This works:
+	assert.Equal(t, ab, pb, "encoding doesn't match")
 }