From 08982c81fc0c83504df4b4043e7a6e9bb0ba4550 Mon Sep 17 00:00:00 2001 From: Sam Kleinman Date: Fri, 24 Sep 2021 13:49:06 -0400 Subject: [PATCH] e2e: skip validation of status apphash (#6991) I believe this assertion is likely redundant given that we're checking the block apphash. --- test/e2e/tests/app_test.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/test/e2e/tests/app_test.go b/test/e2e/tests/app_test.go index 4387b98cd..afd4d2d52 100644 --- a/test/e2e/tests/app_test.go +++ b/test/e2e/tests/app_test.go @@ -44,17 +44,15 @@ func TestApp_Hash(t *testing.T) { require.NoError(t, err) require.NotEmpty(t, info.Response.LastBlockAppHash, "expected app to return app hash") - status, err := client.Status(ctx) - require.NoError(t, err) - if info.Response.LastBlockHeight == status.SyncInfo.LatestBlockHeight { - require.EqualValues(t, info.Response.LastBlockAppHash, status.SyncInfo.LatestAppHash, - "app hash does not match node status") - } - block, err := client.Block(ctx, &info.Response.LastBlockHeight) require.NoError(t, err) require.EqualValues(t, info.Response.LastBlockAppHash, block.Block.AppHash.Bytes(), "app hash does not match last block's app hash") + + status, err := client.Status(ctx) + require.NoError(t, err) + require.True(t, status.SyncInfo.LatestBlockHeight >= info.Response.LastBlockHeight, + "status out of sync with application") }) }